bug: Don't clone DOM node that's only referenced once

maxmilton · maxmilton · commit ffa77c7d32fd · 2022-05-10T11:44:15.000+10:00
diff --git a/src/components/Reader.ts b/src/components/Reader.ts
@@ -48,7 +48,7 @@ function timeoutMultiplier(word: string, jumped?: boolean) {
 }
 
 interface UserSettings {
-  /** Words Per Minute. */
+  /** Targeted words per minute. */
   wpm?: number;
 }
 
@@ -85,7 +85,7 @@ const view = h(`
 `);
 
 export function Reader(): ReaderComponent {
-  const root = view.cloneNode(true) as ReaderComponent;
+  const root = view as ReaderComponent;
   const {
     progress, rewind, play, slower, speed, faster, w, focus,
   } = view.collect<RefNodes>(root);

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ function timeoutMultiplier(word: string, jumped?: boolean) {`
`48`	`48`	`}`
`49`	`49`
`50`	`50`	`interface UserSettings {`
`51`		`- /** Words Per Minute. */`
	`51`	`+ /** Targeted words per minute. */`
`52`	`52`	`wpm?: number;`
`53`	`53`	`}`
`54`	`54`
@@ -85,7 +85,7 @@ const view = h(`
`85`	`85`	`);
`86`	`86`
`87`	`87`	`export function Reader(): ReaderComponent {`
`88`		`- const root = view.cloneNode(true) as ReaderComponent;`
	`88`	`+ const root = view as ReaderComponent;`
`89`	`89`	`const {`
`90`	`90`	`progress, rewind, play, slower, speed, faster, w, focus,`
`91`	`91`	`} = view.collect<RefNodes>(root);`