Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: maxmind/MaxMind-DB-Reader-java
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: maxmind/MaxMind-DB-Reader-java
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: greg/support-temporal-decoding
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 4 commits
  • 7 files changed
  • 1 contributor

Commits on Oct 14, 2025

  1. Support fallback constructor/parameter selection

    - Prefer @MaxMindDbConstructor; fallback to record canonical or single
      public constructor
    - Infer parameter names: annotation > record component > Java parameter
      when `-parameters` is set; throw ParameterNotFoundException if names
      unavailable
    - Enable -parameters in maven-compiler-plugin
    oschwald committed Oct 14, 2025
    Configuration menu
    Copy the full SHA
    4b36416 View commit details
    Browse the repository at this point in the history
  2. Decode int primitive constructor params

    Add coercion for INT32/UINT16/UINT32 to target primitives with range
    checks.
    oschwald committed Oct 14, 2025
    Configuration menu
    Copy the full SHA
    59c7501 View commit details
    Browse the repository at this point in the history
  3. Defaults for missing constructor params via annotation

    We need both useDefault and defaultValue as otherwise there is no way
    to distinguish between the default value being the empty string and
    no default being set. If defaultValue is not set but useDefault is, we
    will use the Java default value, e.g., 0 or the empty string.
    oschwald committed Oct 14, 2025
    Configuration menu
    Copy the full SHA
    3352b5e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ed6699c View commit details
    Browse the repository at this point in the history
Loading