Merge pull request #61 from mendix/ufc/940-pending-link

Robinfr · web-flow · commit a35a2ab47975 · 2023-11-01T16:21:45.000+01:00
[UFC-940] Fix access rules pending link (Mx10)
diff --git a/src/DeepLinkModule/[App Store] Deeplink.mpr b/src/DeepLinkModule/[App Store] Deeplink.mpr
diff --git a/src/DeepLinkModule/javasource/deeplink/actions/ExecuteDeeplink.java b/src/DeepLinkModule/javasource/deeplink/actions/ExecuteDeeplink.java
@@ -112,17 +112,18 @@ public java.lang.Boolean executeAction() throws Exception
 				LOG.error("Failed to execute deeplink " + link.getName(), e);
 				return false;
 			}
+			
+			IContext sudoContext = getContext().createSudoClone();
 
 			//remove the pendinglink, unless it should be reused during this session..
 			if (link.getUseAsHome()) { //do not remove if used as home.
-				this.pendinglink.setSessionId(this.getContext().getSession().getId().toString());
-				Core.commit(this.getContext(), this.pendinglink.getMendixObject());
+				this.pendinglink.setSessionId(sudoContext, this.getContext().getSession().getId().toString());
+				Core.commit(sudoContext, this.pendinglink.getMendixObject());
 			}
 			else {
 				Core.delete(this.getContext(), this.pendinglink.getMendixObject());
 			}
 
-			IContext sudoContext = getContext().createSudoClone();
 			if(link.getTrackHitCount(sudoContext)) {
 				//set hitcount (note, this might not be exact)
 				link.setHitCount(sudoContext, link.getHitCount(sudoContext) + 1);
diff --git a/src/DeepLinkModule/javasource/deeplink/implementation/handler/DeeplinkHandler.java b/src/DeepLinkModule/javasource/deeplink/implementation/handler/DeeplinkHandler.java
@@ -93,8 +93,7 @@ else if(DeeplinkHandler.SSOHandler != null) {
 						} 
 					}
 					else {
-		
-						PendingLink preparedPendingLink = preparePendingLink(sessionContext, session, deepLinkConfigurationObject, deepLinkRequest);
+						PendingLink preparedPendingLink = preparePendingLink(sessionContext.createSudoClone(), session, deepLinkConfigurationObject, deepLinkRequest);
 		
 						if(preparedPendingLink == null) {
 							ResponseHandler.serve404(response);

Original file line number	Diff line number	Diff line change
`@@ -93,8 +93,7 @@ else if(DeeplinkHandler.SSOHandler != null) {`
`93`	`93`	`}`
`94`	`94`	`}`
`95`	`95`	`else {`
`96`		`-`
`97`		`- PendingLink preparedPendingLink = preparePendingLink(sessionContext, session, deepLinkConfigurationObject, deepLinkRequest);`
	`96`	`+ PendingLink preparedPendingLink = preparePendingLink(sessionContext.createSudoClone(), session, deepLinkConfigurationObject, deepLinkRequest);`
`98`	`97`
`99`	`98`	`if(preparedPendingLink == null) {`
`100`	`99`	`ResponseHandler.serve404(response);`