Added SSL Identity check configuration option

RoelandSalij · RoelandSalij · commit a1deb94708ff · 2020-03-26T17:20:24.000+01:00
diff --git a/src/EmailModuleWithTemplates/[App Store] Email template.mpr b/src/EmailModuleWithTemplates/[App Store] Email template.mpr
diff --git a/src/EmailModuleWithTemplates/javasource/emailtemplate/actions/SendEmail.java b/src/EmailModuleWithTemplates/javasource/emailtemplate/actions/SendEmail.java
@@ -43,8 +43,9 @@ public class SendEmail extends CustomJavaAction<java.lang.Boolean>
 	private java.lang.Boolean UseSSL;
 	private java.lang.Boolean UseTLS;
 	private java.lang.String FromDisplayName;
+	private java.lang.Boolean UseSSLCheckIdentity;
 
-	public SendEmail(IContext context, java.lang.String SMTPHost, java.lang.String SMTPUserName, java.lang.String SMTPPassword, java.lang.String CCAddresses, java.lang.String BCCAddresses, java.lang.String ToAddresses, java.lang.String FromAddress, java.lang.String ReplyToAddress, java.lang.String HtmlBody, java.lang.String PlainBody, java.lang.String Subject, java.lang.Long SMTPPort, java.util.List<IMendixObject> AttachmentList, java.util.List<IMendixObject> HeaderList, java.lang.Boolean UseSSL, java.lang.Boolean UseTLS, java.lang.String FromDisplayName)
+	public SendEmail(IContext context, java.lang.String SMTPHost, java.lang.String SMTPUserName, java.lang.String SMTPPassword, java.lang.String CCAddresses, java.lang.String BCCAddresses, java.lang.String ToAddresses, java.lang.String FromAddress, java.lang.String ReplyToAddress, java.lang.String HtmlBody, java.lang.String PlainBody, java.lang.String Subject, java.lang.Long SMTPPort, java.util.List<IMendixObject> AttachmentList, java.util.List<IMendixObject> HeaderList, java.lang.Boolean UseSSL, java.lang.Boolean UseTLS, java.lang.String FromDisplayName, java.lang.Boolean UseSSLCheckIdentity)
 	{
 		super(context);
 		this.SMTPHost = SMTPHost;
@@ -64,6 +65,7 @@ public SendEmail(IContext context, java.lang.String SMTPHost, java.lang.String S
 		this.UseSSL = UseSSL;
 		this.UseTLS = UseTLS;
 		this.FromDisplayName = FromDisplayName;
+		this.UseSSLCheckIdentity = UseSSLCheckIdentity;
 	}
 
 	@java.lang.Override
@@ -110,6 +112,7 @@ public java.lang.Boolean executeAction() throws Exception
 		config.setUserPass((this.SMTPPassword != null ? this.SMTPPassword : ""));
 		config.setUseSSLSMTP(this.UseSSL);
 		config.setUseTLSSMTP(this.UseTLS);
+		config.setUseSSLCheckServerIdentity(this.UseSSLCheckIdentity);
 
 		String separator = (String) emailtemplate.proxies.constants.Constants.getEmailAddressSeparator();
 		if (separator == null)
diff --git a/src/EmailModuleWithTemplates/javasource/emailtemplate/mail/SMTPConfiguration.java b/src/EmailModuleWithTemplates/javasource/emailtemplate/mail/SMTPConfiguration.java
@@ -9,6 +9,7 @@ public class SMTPConfiguration
 	private String userPass;
 	
 	private boolean useSSLSMTP;
+	private boolean useSSLCheckServerIdentity;
 	private boolean useTLSSMTP;
 	
 	private String fromAddress;
@@ -20,6 +21,7 @@ public SMTPConfiguration()
 		// Basic configuration
 		this.useSSLSMTP = false;
 		this.useTLSSMTP = false;
+		this.useSSLCheckServerIdentity = false;
 		this.SMTPPort = 25;
 		this.SMTPHost = "";
 		this.userName = "";
@@ -119,5 +121,15 @@ public void setReplyToAddress(String replyToAddress)
 		this.replyToAddress = replyToAddress;
 	}
 
+	public boolean useSSLCheckServerIdentity() 
+	{
+		return this.useSSLCheckServerIdentity;
+	}
+
+	public void setUseSSLCheckServerIdentity(boolean useSSLCheckServerIdentity) 
+	{
+		this.useSSLCheckServerIdentity = useSSLCheckServerIdentity;
+	}
+
 
 }
diff --git a/src/EmailModuleWithTemplates/javasource/emailtemplate/mail/Sender.java b/src/EmailModuleWithTemplates/javasource/emailtemplate/mail/Sender.java
@@ -238,6 +238,8 @@ private void setConnectionInfo(Email mail, SMTPConfiguration configuration)
 	        mail.setStartTLSEnabled(true);
 	    }
 	    
+	    mail.setSSLCheckServerIdentity(configuration.useSSLCheckServerIdentity());
+	    
 	    /* because the default session mechanisms uses System.getProperties() (which is not allowed 
 	     * in the cloud), we need to construct a session ourselves. The code to do this was lifted
 	     * from Email.java in the commons-email package.

Original file line number	Diff line number	Diff line change
`@@ -238,6 +238,8 @@ private void setConnectionInfo(Email mail, SMTPConfiguration configuration)`
`238`	`238`	`mail.setStartTLSEnabled(true);`
`239`	`239`	`}`
`240`	`240`
	`241`	`+ mail.setSSLCheckServerIdentity(configuration.useSSLCheckServerIdentity());`
	`242`	`+`
`241`	`243`	`/* because the default session mechanisms uses System.getProperties() (which is not allowed`
`242`	`244`	`* in the cloud), we need to construct a session ourselves. The code to do this was lifted`
`243`	`245`	`* from Email.java in the commons-email package.`