Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: method-security/methodaws
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: develop
Choose a base ref
...
head repository: method-security/methodaws
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: apurva/elasticbeanstalk-takeover
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 9 commits
  • 83 files changed
  • 2 contributors

Commits on Jul 25, 2025

  1. add takeover

    @apurvagoenka-method
    apurvagoenka-method committed Jul 25, 2025
    Configuration menu
    Copy the full SHA
    64b1d43 View commit details
    Browse the repository at this point in the history

  2. Remove methodaws binary and add to .gitignore 

    🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
    @apurvagoenka-method @claude
    apurvagoenka-method and claude committed Jul 25, 2025
    Configuration menu
    Copy the full SHA
    8b84f82 View commit details
    Browse the repository at this point in the history

  3. rev

    @apurvagoenka-method
    apurvagoenka-method committed Jul 25, 2025
    Configuration menu
    Copy the full SHA
    5d5f560 View commit details
    Browse the repository at this point in the history

  4. Add DNS availability checking for ElasticBeanstalk environments 

    - Add CheckDNSAvailability function to internal/elasticbeanstalk package
- Update Fern definitions with DNS availability types
- Integrate DNS check into create-environment command (validates before creation)
- Add standalone check-dns-availability command
- Both commands use Fern-generated structs for consistent API structure

Usage:
- methodaws elasticbeanstalk check-dns-availability -r us-east-1 --cname-prefix my-app
- methodaws elasticbeanstalk create-environment -r us-east-1 --cname-prefix my-app
  (now checks DNS availability before attempting to create environment)

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
    @apurvagoenka-method @claude
    apurvagoenka-method and claude committed Jul 25, 2025
    Configuration menu
    Copy the full SHA
    ac1774a View commit details
    Browse the repository at this point in the history

  5. Align ElasticBeanstalk report structure with S3 external enumeration … 

    …pattern

- Update Fern definitions to match S3 external enumeration structure
- Add ElasticBeanstalkCreateEnvironmentConfig for configuration parameters
- Restructure ElasticBeanstalkCreateEnvironmentReport to include:
  - result: wraps the environment data
  - errors: optional list of error strings
  - config: contains configurable flags (cname-prefix, region, etc.)
- Update internal implementation to use new report structure
- Update CLI command error handling for new structure

This aligns with the existing S3 external enumeration pattern providing
consistent API structure across all methodaws commands.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
    @apurvagoenka-method @claude
    apurvagoenka-method and claude committed Jul 25, 2025
    Configuration menu
    Copy the full SHA
    b6eef6e View commit details
    Browse the repository at this point in the history

  6. Add structured logging using svc1log for ElasticBeanstalk operations 

    - Import svc1log in internal/elasticbeanstalk package
- Add comprehensive logging to CreateEnvironment function:
  - Info log on start with environment details
  - Error log on failures with context
  - Success log with environment ID and CNAME
- Add logging to CheckDNSAvailability function:
  - Info log on start with CNAME prefix
  - Error log on API failures
  - Info log on completion with availability status
- Add warning log in CLI when CNAME prefix is unavailable
- Use SafeParam for all logged parameters following methodaws patterns
- Integrate with existing svc1log context from CLI commands

All logging follows the established svc1log patterns used throughout
the methodaws codebase for consistent structured logging.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
    @apurvagoenka-method @claude
    apurvagoenka-method and claude committed Jul 25, 2025
    Configuration menu
    Copy the full SHA
    24f527a View commit details
    Browse the repository at this point in the history

  7. Remove redundant region validation checks in ElasticBeanstalk commands 

    - Remove unnecessary region length checks in both create-environment and check-dns-availability commands
- Region validation is already handled by PersistentPreRunE in the root command
- Since we explicitly require regions, this redundant validation will never be reached
- Simplifies code and reduces unnecessary error handling paths

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
    @apurvagoenka-method @claude
    apurvagoenka-method and claude committed Jul 25, 2025
    Configuration menu
    Copy the full SHA
    10cf14f View commit details
    Browse the repository at this point in the history

  8. fixes

    @apurvagoenka-method
    apurvagoenka-method committed Jul 25, 2025
    Configuration menu
    Copy the full SHA
    9d13db7 View commit details
    Browse the repository at this point in the history

  9. Fix golint issue: rename checkDnsCmd to checkDNSCmd

    @apurvagoenka-method
    apurvagoenka-method committed Jul 25, 2025
    Configuration menu
    Copy the full SHA
    3ae49b2 View commit details
    Browse the repository at this point in the history
Loading