Skip to content

Bug fixes preventing automatic startup scripts from running#90

Merged
Michaelcraun merged 2 commits intov1.3.0from
mc/bug-fixes
Nov 24, 2022
Merged

Bug fixes preventing automatic startup scripts from running#90
Michaelcraun merged 2 commits intov1.3.0from
mc/bug-fixes

Conversation

@Michaelcraun
Copy link
Copy Markdown
Collaborator

What changed?

  • Parameters in several methods in extensions.py were created with the wrong types
  • Boyscouting: renamed methods in extensions.py to be much more pythonic
  • Boyscouting: removed extraneous imports in cron.py

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Does this introduce a breaking change?

  • Yes
  • No

Other information

Checklist

Please ensure the following items are taken care of as part of your PR. If they are not, your PR will NOT be approved!

  • You have added docstrings to any user-facing functions
  • You have updated the CHANGELOG.md file with your changes

@Michaelcraun Michaelcraun linked an issue Apr 5, 2022 that may be closed by this pull request
@Michaelcraun Michaelcraun requested a review from BAChapin July 16, 2022 15:00
@Michaelcraun Michaelcraun requested review from BAChapin and removed request for BAChapin November 24, 2022 14:11
Copy link
Copy Markdown
Member

@BAChapin BAChapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to update the CHANGELOG.md with the changes you made in this PR, and don't forget to rebase.

- cleanString(haystack:needeles:) and stringContainsAnyCase(haystack:needles:) had the incorrect syntax when declaring the type of the needles parameter.
- Boyscout: Also renamed to clean_string and string_contains_any_case to match pythonic syntax
@Michaelcraun Michaelcraun merged commit 6c74cc2 into v1.3.0 Nov 24, 2022
@Michaelcraun Michaelcraun deleted the mc/bug-fixes branch November 24, 2022 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug in extensions.py that is preventing cron from running

2 participants