Closed
Conversation
Remove 'anchor-1.0' and 'fix-biome-errors' from push branch triggers — these branches are stale and CI should only trigger on 'main'. Remove FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 env var from all workflows. Despite the comments, this is not a real GitHub Actions feature and has no effect on which Node.js runtime actions use.
All other workflows already use pnpm/action-setup@v4 to install pnpm. The anchor workflow was the odd one out, using 'npm i -g pnpm' instead. Switch to the proper action for consistency and to get pnpm caching support.
The build step generates IDL files and TypeScript types that the test dependencies need. Running pnpm install first means those generated files aren't available during dependency resolution/linking. Reorder to: anchor build → pnpm install → anchor test --skip-build. Also pass --skip-build to anchor test since the program is already built, avoiding a redundant rebuild.
POSIX text files should end with a newline. The missing newline could cause issues with tools that concatenate or process the file line by line (e.g. the grep/tr pipeline in the CI workflows).
Collaborator
|
Out of date |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean up CI workflows without changing any program code or versions.
Changes
Remove stale branch triggers —
anchor-1.0andfix-biome-errorsbranches no longer exist; remove them from push triggers across all 5 workflows.Remove fake
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24env var — This isn't a real GitHub Actions feature and does nothing. Removed from all workflows.Use
pnpm/action-setupin anchor workflow — All other workflows already usepnpm/action-setup@v4; anchor.yml was the outlier usingnpm i -g pnpm.Reorder anchor CI: build before install —
anchor buildgenerates IDL and types thatpnpm installdependencies need. Reordered to: build → install → test (with--skip-buildto avoid redundant rebuilds).Fix missing trailing newline in .ghaignore — POSIX compliance.
6 files changed, +16 / -41