Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: xwb1989/sqlparser
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: mkasner/sqlparser
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 19 commits
  • 12 files changed
  • 9 contributors

Commits on Mar 11, 2020

  1. move FormatBindVariables into sqltypes 

    Extract the common functionality for formatting bind variables
out from both vtgate and vttablet's query logging modules into
a sqltypes.FormatBindVariables helper.

Signed-off-by: Michael Demmer <[email protected]>
    @demmer @mkasner
    demmer authored and mkasner committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    4da3102 View commit details
    Browse the repository at this point in the history

  2. #4145 backwards compatible ascii encoding for bit literals 

    Signed-off-by: deepthi <[email protected]>
    @deepthi @mkasner
    deepthi authored and mkasner committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    cd99ea3 View commit details
    Browse the repository at this point in the history

  3. #4145 changes based on review 

    Signed-off-by: deepthi <[email protected]>
    @deepthi @mkasner
    deepthi authored and mkasner committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    42f6245 View commit details
    Browse the repository at this point in the history

  4. add a sqltypes.NewUint32 helper 

    Signed-off-by: Michael Demmer <[email protected]>
    @demmer @mkasner
    demmer authored and mkasner committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    8357a8f View commit details
    Browse the repository at this point in the history

  5. staticcheck: packages/files missed during first pass 

    Signed-off-by: deepthi <[email protected]>
    @deepthi @mkasner
    deepthi authored and mkasner committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    1d30398 View commit details
    Browse the repository at this point in the history

  6. bind_variables: bool to INT8 

    Signed-off-by: Creed Haymond <[email protected]>
    @creedasaurus @mkasner
    creedasaurus authored and mkasner committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    3695cba View commit details
    Browse the repository at this point in the history

  7. Added python end to end test 

    Signed-off-by: Saif Alharthi <[email protected]>
    @saifalharthi @mkasner
    saifalharthi authored and mkasner committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    465157a View commit details
    Browse the repository at this point in the history

  8. Fix TestTypeError 

    Signed-off-by: Saif Alharthi <[email protected]>
    @saifalharthi @mkasner
    saifalharthi authored and mkasner committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    6a62069 View commit details
    Browse the repository at this point in the history

  9. minor 

    Signed-off-by: Nitin Shatma <[email protected]>
    @mkasner
    Nitin Shatma authored and mkasner committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    1e1bfa3 View commit details
    Browse the repository at this point in the history

  10. fix-test 

    Signed-off-by: Nitin Shatma <[email protected]>
    @mkasner
    Nitin Shatma authored and mkasner committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    779d104 View commit details
    Browse the repository at this point in the history

  11. add-type-equivalence 

    Signed-off-by: Nitin Shatma <[email protected]>
    @mkasner
    Nitin Shatma authored and mkasner committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    b62b9a1 View commit details
    Browse the repository at this point in the history

  12. address-review-feedback 

    Signed-off-by: Nitin Shatma <[email protected]>
    @mkasner
    Nitin Shatma authored and mkasner committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    0a7fa3f View commit details
    Browse the repository at this point in the history

  13. Use the import () way 

    Signed-off-by: xichengliudui <[email protected]>
    @xichengliudui @mkasner
    xichengliudui authored and mkasner committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    acf58af View commit details
    Browse the repository at this point in the history

  14. add license in /go file 

    Signed-off-by: yuxiaobo <[email protected]>
    @yuxiaobo96 @mkasner
    yuxiaobo96 authored and mkasner committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    28abfc1 View commit details
    Browse the repository at this point in the history

  15. Use the import () way 

    Signed-off-by: xichengliudui <[email protected]>
    @xichengliudui @mkasner
    xichengliudui authored and mkasner committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    f070f26 View commit details
    Browse the repository at this point in the history

  16. codegen: use strings.Builder instead of hack 

    For the sake of efficiency, we used to 'hack' some places
by coercing a []byte into a string. This hack is now officially
encapsulated safely by strings.Builder.

The last place where we're still using hack.String is in
sqltypes.Value. That will require some thinking.

I've also deleted code for other hacks that we don't use any more.

Signed-off-by: Sugu Sougoumarane <[email protected]>
    @sougou @mkasner
    sougou authored and mkasner committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    eab0c5c View commit details
    Browse the repository at this point in the history

  17. add license in /go file 

    Signed-off-by: yuxiaobo <[email protected]>
    @yuxiaobo96 @mkasner
    yuxiaobo96 authored and mkasner committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    e322a71 View commit details
    Browse the repository at this point in the history

  18. Ports latest changes from upstream. Updates README with latest commit

    @mkasner
    mkasner committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    fcb5647 View commit details
    Browse the repository at this point in the history

  19. Introduces option which doesn't replace question mark params with nam… 

    …ed params
    @mkasner
    mkasner committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    104ddd9 View commit details
    Browse the repository at this point in the history
Loading