Remove sign key exchange preference

Lilia Markham · Lilia Markham · commit e3c5e837e1ad · 2013-03-27T20:57:28.000-07:00
Yet another setting that most users will never touch. Workaround for
those who would is to use a different identity key per device.

Let this be a sacrifice to the android settings design pattern gods.
diff --git a/res/xml/preferences.xml b/res/xml/preferences.xml
@@ -66,11 +66,6 @@
                            android:title="@string/preferences__complete_key_exchanges"
                            android:summary="@string/preferences__automatically_complete_key_exchanges_for_new_sessions_or_for_existing_sessions_with_the_same_identity_key" />
 
-    <CheckBoxPreference android:defaultValue="true"
-                        android:key="pref_send_identity_key"
-                        android:summary="@string/preferences__sign_key_exchange_messages_with_identity_key"
-                        android:title="@string/preferences__sign_key_exchange" />
-
     <CheckBoxPreference android:defaultValue="false"
                         android:key="pref_timeout_passphrase"
                         android:summary="@string/preferences__forget_passphrase_from_memory_after_some_interval"
diff --git a/src/org/thoughtcrime/securesms/ApplicationPreferencesActivity.java b/src/org/thoughtcrime/securesms/ApplicationPreferencesActivity.java
@@ -63,7 +63,6 @@ public class ApplicationPreferencesActivity extends PassphraseRequiredSherlockPr
   public static final String LED_BLINK_PREF                   = "pref_led_blink";
   public static final String LED_BLINK_PREF_CUSTOM            = "pref_led_blink_custom";
   public static final String IDENTITY_PREF                    = "pref_choose_identity";
-  public static final String SEND_IDENTITY_PREF               = "pref_send_identity_key";
   public static final String ALL_MMS_PERF                     = "pref_all_mms";
   public static final String PASSPHRASE_TIMEOUT_INTERVAL_PREF = "pref_timeout_interval";
   public static final String PASSPHRASE_TIMEOUT_PREF          = "pref_timeout_passphrase";
diff --git a/src/org/thoughtcrime/securesms/crypto/KeyExchangeMessage.java b/src/org/thoughtcrime/securesms/crypto/KeyExchangeMessage.java
@@ -115,9 +115,7 @@ public KeyExchangeMessage(String messageBody) throws InvalidVersionException, In
   }
 	
   private static boolean includeIdentitySignature(int messageVersion, Context context) {
-    return IdentityKeyUtil.hasIdentityKey(context) && 
-      (messageVersion >= 1)                   &&
-      PreferenceManager.getDefaultSharedPreferences(context).getBoolean(ApplicationPreferencesActivity.SEND_IDENTITY_PREF, true);
+    return IdentityKeyUtil.hasIdentityKey(context) && (messageVersion >= 1);
   }
 
 	

Original file line number	Diff line number	Diff line change
`@@ -115,9 +115,7 @@ public KeyExchangeMessage(String messageBody) throws InvalidVersionException, In`
`115`	`115`	`}`
`116`	`116`
`117`	`117`	`private static boolean includeIdentitySignature(int messageVersion, Context context) {`
`118`		`- return IdentityKeyUtil.hasIdentityKey(context) &&`
`119`		`- (messageVersion >= 1) &&`
`120`		`- PreferenceManager.getDefaultSharedPreferences(context).getBoolean(ApplicationPreferencesActivity.SEND_IDENTITY_PREF, true);`
	`118`	`+ return IdentityKeyUtil.hasIdentityKey(context) && (messageVersion >= 1);`
`121`	`119`	`}`
`122`	`120`
`123`	`121`