Fix error message on invalid ymmsl_version tag

LourensVeen · LourensVeen · commit 2c06bce2b0d0 · 2026-02-11T13:09:49.000+01:00
diff --git a/ymmsl/command_line.py b/ymmsl/command_line.py
@@ -1,7 +1,7 @@
 import click
 import os
 from shutil import copyfile
-from typing import Optional, TextIO, Type, Union
+from typing import Dict, Optional, TextIO, Type, Union
 import warnings
 
 from ymmsl.conversion.converter import DowngradeError
@@ -31,7 +31,7 @@ def ymmsl() -> None:
     pass
 
 
-_version_tag_to_type = {
+_version_tag_to_type: Dict[str, Type] = {
         'v0.1': v0_1.PartialConfiguration,
         'v0.2': v0_2.Configuration,
         }
diff --git a/ymmsl/document.py b/ymmsl/document.py
@@ -1,4 +1,7 @@
-class Document:
+from abc import ABC
+
+
+class Document(ABC):
     """Base class for ymmsl documents of all versions"""
     def __init__(self) -> None:
         pass
diff --git a/ymmsl/tests/test_io.py b/ymmsl/tests/test_io.py
@@ -0,0 +1,10 @@
+import ymmsl
+import yatiml
+
+import pytest
+
+
+def test_invalid_version() -> None:
+    """This is a regression test, the error was really confusing"""
+    with pytest.raises(yatiml.RecognitionError):
+        ymmsl.load('ymmsl_version: v0_1')
diff --git a/ymmsl/v0_1/configuration.py b/ymmsl/v0_1/configuration.py
@@ -341,6 +341,7 @@ def check_consistent(self) -> None:
 
     @classmethod
     def _yatiml_recognize(cls, node: yatiml.UnknownNode) -> None:
+        Document._yatiml_recognize(node)
         node.require_attribute('model', Model)
         node.require_attribute('implementations')
         node.require_attribute('resources')
diff --git a/ymmsl/v0_1/document.py b/ymmsl/v0_1/document.py
@@ -6,9 +6,8 @@
 class Document(DocumentBase):
     """Represents a yMMSL document.
 
-    This gets mixed in with a top-level content class, and takes
-    care of a special ymmsl_version attribute in the root of the
-    YAML file.
+    This gets specialised by a top-level content class, and takes care of a special
+    ymmsl_version attribute in the root of the YAML file.
     """
 
     @classmethod
diff --git a/ymmsl/v0_2/document.py b/ymmsl/v0_2/document.py
@@ -6,9 +6,8 @@
 class Document(DocumentBase):
     """Represents a yMMSL document.
 
-    This gets mixed in with a top-level content class, and takes
-    care of a special ymmsl_version attribute in the root of the
-    YAML file.
+    This gets specialised by a top-level content class, and takes care of a special
+    ymmsl_version attribute in the root of the YAML file.
     """
 
     @classmethod
