Add warning about comments not being converted

LourensVeen · LourensVeen · commit 533d63c76ab4 · 2026-02-02T14:47:17.000+01:00
diff --git a/ymmsl/conversion/convert_v0_1_to_v0_2.py b/ymmsl/conversion/convert_v0_1_to_v0_2.py
@@ -34,6 +34,10 @@ def convert_v0_1_to_v0_2(config: v0_1.PartialConfiguration) -> v0_2.Configuratio
     checkpoints = deepcopy(config.checkpoints)
     resume = deepcopy(config.resume)
 
+    warnings.warn(
+            'Comments can unfortunately not be read by this converter, and so have been'
+            ' ignored. Please copy them into an appropriate description field.')
+
     return v0_2.Configuration(
             description, None, models, None, settings, programs, resources, checkpoints,
             resume)
diff --git a/ymmsl/conversion/tests/test_convert_v0_1_to_v0_2.py b/ymmsl/conversion/tests/test_convert_v0_1_to_v0_2.py
@@ -14,8 +14,10 @@
 Ref2 = v0_2.Reference
 
 
+@pytest.mark.filterwarnings('ignore:Comments.*')
 def test_convert_simple_config(empty_config: v0_1.PartialConfiguration) -> None:
     v2 = convert_v0_1_to_v0_2(empty_config)
+
     assert v2.description == 'Please add a description'
     assert isinstance(v2.settings, v0_2.Settings)
     assert len(v2.settings) == 0
@@ -27,9 +29,10 @@ def test_convert_simple_config(empty_config: v0_1.PartialConfiguration) -> None:
     assert v2.resume == {}
 
 
+@pytest.mark.filterwarnings('ignore:Comments.*')
+@pytest.mark.filterwarnings('ignore:.*implementations have become programs.*')
 def test_convert_full_config(full_config: v0_1.Configuration) -> None:
-    with pytest.warns(UserWarning):
-        v2 = convert_v0_1_to_v0_2(full_config)
+    v2 = convert_v0_1_to_v0_2(full_config)
     assert v2.description == 'Testing a full configuration'
 
     assert v2.settings is not full_config.settings
diff --git a/ymmsl/conversion/tests/test_converter.py b/ymmsl/conversion/tests/test_converter.py
@@ -14,6 +14,7 @@ def test_convert_to_no_change(full_config: v0_1.PartialConfiguration) -> None:
 
 
 @pytest.mark.filterwarnings('ignore:.*specify the ports.*')
+@pytest.mark.filterwarnings('ignore:Comments.*')
 def test_convert_to(full_config: v0_1.PartialConfiguration) -> None:
     new_config = convert_to(v0_2.Configuration, full_config)
     assert isinstance(new_config, v0_2.Configuration)
diff --git a/ymmsl/tests/test_load_as.py b/ymmsl/tests/test_load_as.py
@@ -4,13 +4,16 @@
 import ymmsl.v0_1 as v0_1
 import ymmsl.v0_2 as v0_2
 
+import pytest
+
 
 def test_load_as_v0_1(test_yaml1: str) -> None:
     config = load_as(v0_1.PartialConfiguration, test_yaml1)
     assert isinstance(config, v0_1.PartialConfiguration)
     assert cast(List[int], config.settings['test_list'])[0] == 12.3
 
 
+@pytest.mark.filterwarnings('ignore:Comments.*')
 def test_load_as_v0_2(test_yaml1: str) -> None:
     config = load_as(v0_2.Configuration, test_yaml1)
     assert isinstance(config, v0_2.Configuration)
