From d0bb116f9e4946ce85fa77e6d2540f334ec69ee0 Mon Sep 17 00:00:00 2001
From: Peter Hunt <peter.hunt@bglgroup.co.uk>
Date: Thu, 25 Jul 2019 08:38:20 +0100
Subject: [PATCH 1/2] :bug: Fix behaviour of Repository#getReferences; filter
 and map do not work in-place

---
 lib/repository.js | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/lib/repository.js b/lib/repository.js
index 29c429fad..45669e698 100644
--- a/lib/repository.js
+++ b/lib/repository.js
@@ -351,14 +351,12 @@ Repository.initExt = function(repo_path, opts) {
 
 Repository.getReferences = function(repo, type, refNamesOnly) {
   return repo.getReferences().then(function(refList) {
-    var filteredRefList = refList;
-
-    filteredRefList.filter(function(reference) {
-      return type == Reference.TYPE.LISTALL || reference.type === type;
+    var filteredRefList = refList.filter(function(reference) {
+      return type === Reference.TYPE.LISTALL || reference.type === type;
     });
 
     if (refNamesOnly) {
-      filteredRefList.map(function(reference) {
+      return filteredRefList.map(function(reference) {
         return reference.name();
       });
     }
@@ -1255,8 +1253,8 @@ Repository.prototype.getReferenceCommit = function(name, callback) {
  * @param {Reference.TYPE} type Type of reference to look up
  * @return {Array<String>}
  */
-Repository.prototype.getReferenceNames = function(type, callback) {
-  return Repository.getReferences(this, type, true, callback);
+Repository.prototype.getReferenceNames = function(type) {
+  return Repository.getReferences(this, type, true);
 };
 
 /**

From 58ab918c65cb5e86096c3dbce462685b20efb179 Mon Sep 17 00:00:00 2001
From: Peter Hunt <peter.hunt@bglgroup.co.uk>
Date: Thu, 25 Jul 2019 13:59:36 +0100
Subject: [PATCH 2/2] Reference.TYPE.LISTALL is depreciated in favour of
 TYPE.ALL

---
 lib/repository.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/repository.js b/lib/repository.js
index 45669e698..aa7c406e4 100644
--- a/lib/repository.js
+++ b/lib/repository.js
@@ -352,7 +352,7 @@ Repository.initExt = function(repo_path, opts) {
 Repository.getReferences = function(repo, type, refNamesOnly) {
   return repo.getReferences().then(function(refList) {
     var filteredRefList = refList.filter(function(reference) {
-      return type === Reference.TYPE.LISTALL || reference.type === type;
+      return type === Reference.TYPE.ALL || reference.type === type;
     });
 
     if (refNamesOnly) {