Fix internal paths with ':' characters not getting clean up properly

Thibaut · Thibaut · commit 2813cf9be32c · 2016-05-15T16:18:38.000-04:00
Fix freeCodeCamp#402.
diff --git a/lib/docs/core/filter.rb b/lib/docs/core/filter.rb
@@ -85,5 +85,9 @@ def decode_cloudflare_email(str)
 
       URI.decode(result)
     end
+
+    def clean_path(path)
+      path.gsub %r{[!;:]+}, '-'
+    end
   end
 end
diff --git a/lib/docs/filters/core/internal_urls.rb b/lib/docs/filters/core/internal_urls.rb
@@ -81,6 +81,7 @@ def normalize_url(url, subpath)
     def internal_path_to(url)
       url = index_url if url == root_url
       path = effective_url.relative_path_to(url)
+      path = clean_path(path) if context[:decode_and_clean_paths]
       URL.new(path: path, query: url.query, fragment: url.fragment).to_s
     end
 
diff --git a/lib/docs/filters/core/normalize_paths.rb b/lib/docs/filters/core/normalize_paths.rb
@@ -37,7 +37,7 @@ def normalize_path(path)
 
       if context[:decode_and_clean_paths]
         path = URI.unescape(path)
-        path.gsub! %r{[!;:]+}, '-'
+        path = clean_path(path)
       end
 
       if path == '.'
