Skip to content

Commit 80ec6b3

Browse files
committed
Fix markdownlint failures from the lint workflow's first run
What broke ---------- The lint workflow added in fad7db9 ran for the first time on PR #1 and the markdownlint job reported 34 errors across 4 files. Three were genuine accessibility / structure issues; one was a brittle cosmetic rule. Real content fixes ------------------ SECURITY.md - Line 19: `**[email protected]**` was a bare email. Wrapped in <...> so it renders as a mailto link (`**<[email protected]>**`). Bold preserved. - Line 34: "GitHub's documentation for this flow is [here]" used non-descriptive link text. Rewritten so the link text itself describes the destination ("[private vulnerability reporting flow]"), which is what screen readers and link indexers actually surface. - Lines 65 and 75: `**In scope**` and `**Out of scope**` were bold paragraphs styled as headings. Promoted to real `### ` headings so they appear in the table of contents and get proper landmark navigation. SUPPORT.md - Lines 37 and 45: same pattern - `**We can help with**` and `**We generally cannot help with**` promoted from bold-as- heading to `### ` headings. These are not "make the linter happy" patches - they fix real accessibility issues. Bold text used as a heading is a known a11y antipattern (reported by MD036 for exactly this reason): screen readers don't announce it as a heading, link indexers can't navigate to it, and it doesn't appear in tables of contents. Config change ------------- .markdownlint.jsonc: disable MD060 (table-column-style) with inline rationale. MD060 fires the moment any cell length changes in a table - re-padding sibling rows by hand on every edit is high-friction for zero rendered-output difference. The rule exists because formatters like prettier and mdformat auto-fix it; without one wired up to CI, manually maintaining column alignment is busywork. The 28 MD060 failures across AGENTS.md and ORG_SETTINGS.md were all of this form. If we add a markdown formatter to the lint pipeline later (prettier --write, mdformat, dprint), re-enable MD060. Verification ------------ Re-ran `npx markdownlint-cli2 "**/*.md" "!**/node_modules/**"` locally with the updated config: 0 errors across 10 files. Adheres to the standing rule from AGENTS.md ------------------------------------------- "Don't disable lints, type checks, or tests silently. If you must silence something, leave a same-line comment with the reason." MD060 is now disabled with a multi-line rationale explaining why and what would let us re-enable it. Not silent.
1 parent fad7db9 commit 80ec6b3

3 files changed

Lines changed: 17 additions & 8 deletions

File tree

.markdownlint.jsonc

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,5 +30,13 @@
3030
"MD024": { "siblings_only": true },
3131

3232
// Unordered list indentation — 2 spaces, matching our house style.
33-
"MD007": { "indent": 2 }
33+
"MD007": { "indent": 2 },
34+
35+
// Table-column-style — disabled. Cosmetic rule that fails the moment a
36+
// single cell length changes, requiring all sibling rows to be
37+
// re-padded by hand. This is the kind of thing auto-fixed by prettier
38+
// or mdformat; without one of those formatters wired up, requiring it
39+
// by hand is high-friction for zero rendered-output difference. If we
40+
// add a markdown formatter to CI later, re-enable this rule.
41+
"MD060": false
3442
}

SECURITY.md

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ prefer.
1616

1717
### 1. Email (preferred for first contact from outside GitHub)
1818

19-
Send a report to **[email protected]**.
19+
Send a report to **<[email protected]>**.
2020

2121
If you want to encrypt your report, say so in your first message and we
2222
will respond with a PGP public key.
@@ -30,8 +30,9 @@ Open a private report on the affected repository:
3030
3. Fill in the form. Only the repository's security maintainers will
3131
see the report.
3232

33-
GitHub's own documentation for this flow is
34-
[here][privately-reporting].
33+
GitHub's documentation for the [private vulnerability reporting
34+
flow][privately-reporting] walks through the same steps with
35+
screenshots.
3536

3637
## What to Include
3738

@@ -62,7 +63,7 @@ When you report a vulnerability in good faith, we commit to:
6263

6364
## Scope
6465

65-
**In scope**
66+
### In scope
6667

6768
- Any repository owned by [@nyuchitech](https://github.com/nyuchitech)
6869
unless explicitly marked as archived, experimental, or out of scope
@@ -72,7 +73,7 @@ When you report a vulnerability in good faith, we commit to:
7273
- Build and release infrastructure controlled by the organization
7374
(GitHub Actions workflows, release artifacts).
7475

75-
**Out of scope**
76+
### Out of scope
7677

7778
- Vulnerabilities in third-party dependencies — please report those to
7879
the upstream project. If a dependency issue has a concrete impact on

SUPPORT.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,15 +34,15 @@ A few minutes of prep makes a big difference:
3434

3535
## What we can and cannot help with
3636

37-
**We can help with**
37+
### We can help with
3838

3939
- Bugs and unexpected behavior in code we maintain.
4040
- Documentation that is unclear, incorrect, or missing.
4141
- Reasonable feature requests aligned with a project's scope.
4242
- Security vulnerabilities (via the private channels in
4343
[`SECURITY.md`](./SECURITY.md)).
4444

45-
**We generally cannot help with**
45+
### We generally cannot help with
4646

4747
- One-on-one consulting, custom integrations, or bespoke debugging of
4848
your private code.

0 commit comments

Comments
 (0)