Commit 80ec6b3
committed
Fix markdownlint failures from the lint workflow's first run
What broke
----------
The lint workflow added in fad7db9 ran for the first time on PR #1
and the markdownlint job reported 34 errors across 4 files. Three
were genuine accessibility / structure issues; one was a brittle
cosmetic rule.
Real content fixes
------------------
SECURITY.md
- Line 19: `**[email protected]**` was a bare email. Wrapped
in <...> so it renders as a mailto link
(`**<[email protected]>**`). Bold preserved.
- Line 34: "GitHub's documentation for this flow is [here]"
used non-descriptive link text. Rewritten so the link text
itself describes the destination ("[private vulnerability
reporting flow]"), which is what screen readers and link
indexers actually surface.
- Lines 65 and 75: `**In scope**` and `**Out of scope**` were
bold paragraphs styled as headings. Promoted to real `### `
headings so they appear in the table of contents and get
proper landmark navigation.
SUPPORT.md
- Lines 37 and 45: same pattern - `**We can help with**` and
`**We generally cannot help with**` promoted from bold-as-
heading to `### ` headings.
These are not "make the linter happy" patches - they fix
real accessibility issues. Bold text used as a heading is a
known a11y antipattern (reported by MD036 for exactly this
reason): screen readers don't announce it as a heading, link
indexers can't navigate to it, and it doesn't appear in tables
of contents.
Config change
-------------
.markdownlint.jsonc: disable MD060 (table-column-style) with
inline rationale. MD060 fires the moment any cell length
changes in a table - re-padding sibling rows by hand on every
edit is high-friction for zero rendered-output difference. The
rule exists because formatters like prettier and mdformat
auto-fix it; without one wired up to CI, manually maintaining
column alignment is busywork. The 28 MD060 failures across
AGENTS.md and ORG_SETTINGS.md were all of this form.
If we add a markdown formatter to the lint pipeline later
(prettier --write, mdformat, dprint), re-enable MD060.
Verification
------------
Re-ran `npx markdownlint-cli2 "**/*.md" "!**/node_modules/**"`
locally with the updated config: 0 errors across 10 files.
Adheres to the standing rule from AGENTS.md
-------------------------------------------
"Don't disable lints, type checks, or tests silently. If you
must silence something, leave a same-line comment with the
reason." MD060 is now disabled with a multi-line rationale
explaining why and what would let us re-enable it. Not
silent.1 parent fad7db9 commit 80ec6b3
3 files changed
Lines changed: 17 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
33 | | - | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
34 | 42 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
19 | | - | |
| 19 | + | |
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
| |||
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
33 | | - | |
34 | | - | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
35 | 36 | | |
36 | 37 | | |
37 | 38 | | |
| |||
62 | 63 | | |
63 | 64 | | |
64 | 65 | | |
65 | | - | |
| 66 | + | |
66 | 67 | | |
67 | 68 | | |
68 | 69 | | |
| |||
72 | 73 | | |
73 | 74 | | |
74 | 75 | | |
75 | | - | |
| 76 | + | |
76 | 77 | | |
77 | 78 | | |
78 | 79 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
37 | | - | |
| 37 | + | |
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
45 | | - | |
| 45 | + | |
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
| |||
0 commit comments