Skip to content

Commit 55990b7

Browse files
committed
chore: Remove Oban mentions, as these types could come from anywhere
1 parent 5757a16 commit 55990b7

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

lib/ecto/adapters/libsql/connection.ex

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -422,14 +422,14 @@ defmodule Ecto.Adapters.LibSql.Connection do
422422
defp column_default(value) when is_binary(value), do: " DEFAULT '#{escape_string(value)}'"
423423
defp column_default(value) when is_number(value), do: " DEFAULT #{value}"
424424
defp column_default({:fragment, expr}), do: " DEFAULT #{expr}"
425-
# Handle any other unexpected types (e.g., empty maps from Oban or third-party migrations)
425+
# Handle any other unexpected types (e.g., empty maps or third-party migrations)
426426
# Logs a warning to help with debugging while gracefully falling back to no DEFAULT clause
427427
defp column_default(unexpected) do
428428
require Logger
429429

430430
Logger.warning(
431431
"Unsupported default value type in migration: #{inspect(unexpected)} - " <>
432-
"no DEFAULT clause will be generated. This commonly occurs with Oban-generated migrations " <>
432+
"no DEFAULT clause will be generated. This can occur with some generated migrations " <>
433433
"or other third-party integrations that provide unexpected default types."
434434
)
435435

test/ecto_migration_test.exs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -938,7 +938,7 @@ defmodule Ecto.Adapters.LibSql.MigrationTest do
938938

939939
test "handles unexpected types gracefully (empty map)" do
940940
# This test verifies the catch-all clause for unexpected types.
941-
# Empty maps can come from Oban migrations or other third-party code.
941+
# Empty maps can come from some migrations or other third-party code.
942942
table = %Table{name: :users, prefix: nil}
943943
columns = [{:add, :metadata, :string, [default: %{}]}]
944944

0 commit comments

Comments
 (0)