fix: ensure isolated test data by clearing tables before assertions

ocean · ocean · commit 825d1e27fe1c · 2026-01-12T14:47:59.000+11:00
- Add DELETE FROM test_data before concurrent load tests to ensure exact row count assertions
- Affects three tests: 'connection recovers after query error', 'concurrent load with only NULL values', 'concurrent load with only empty strings'
- Prevents test failures when previous tests leave residual data in shared database
- Ensures each test has a predictable, clean starting state for row count verification
diff --git a/test/pool_load_test.exs b/test/pool_load_test.exs
@@ -403,8 +403,12 @@ defmodule EctoLibSql.PoolLoadTest do
     # Note: This test is sequential (not concurrent) and runs by default.
     # It complements connection_recovery_test.exs by using file-based database.
     test "connection recovers after query error", %{test_db: test_db} do
+      # Clear table first to ensure exact row count assertions
       {:ok, state} = EctoLibSql.connect(database: test_db, busy_timeout: 30_000)
 
+      {:ok, _, _, state} =
+        EctoLibSql.handle_execute("DELETE FROM test_data", [], [], state)
+
       try do
         # Successful insert
         {:ok, _query, _result, state} =
@@ -913,6 +917,14 @@ defmodule EctoLibSql.PoolLoadTest do
     @tag :slow
     @tag :flaky
     test "concurrent load with only NULL values", %{test_db: test_db} do
+      # Clear table first to ensure exact row count assertions
+      {:ok, state} = EctoLibSql.connect(database: test_db, busy_timeout: 30_000)
+
+      {:ok, _, _, state} =
+        EctoLibSql.handle_execute("DELETE FROM test_data", [], [], state)
+
+      EctoLibSql.disconnect([], state)
+
       tasks =
         Enum.map(1..10, fn _i ->
           Task.async(fn ->
@@ -956,6 +968,14 @@ defmodule EctoLibSql.PoolLoadTest do
     @tag :slow
     @tag :flaky
     test "concurrent load with only empty strings", %{test_db: test_db} do
+      # Clear table first to ensure exact row count assertions
+      {:ok, state} = EctoLibSql.connect(database: test_db, busy_timeout: 30_000)
+
+      {:ok, _, _, state} =
+        EctoLibSql.handle_execute("DELETE FROM test_data", [], [], state)
+
+      EctoLibSql.disconnect([], state)
+
       tasks =
         Enum.map(1..10, fn _i ->
           Task.async(fn ->
