Fix: Fix types and test formatting

ocean · ocean · commit a3f06d1283b7 · 2025-12-29T14:33:43.000+11:00
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -55,6 +55,15 @@ jobs:
       - name: Run Rust tests
         run: cargo test --manifest-path native/ecto_libsql/Cargo.toml --all-features
 
+      - name: Install cargo-deny if not present
+        run: |
+          if ! command -v cargo-deny &> /dev/null; then
+            echo "cargo-deny not found, installing..."
+            cargo install cargo-deny --locked
+          else
+            echo "cargo-deny already installed: $(cargo-deny --version)"
+          fi
+
       - name: Check licences and security advisories
         working-directory: native/ecto_libsql
         run: cargo deny check licenses advisories
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -131,7 +131,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 - **License and Security Advisory Checking**
   - Added `cargo-deny` configuration (`deny.toml`) for dependency auditing
-  - Checks for: license compliance, security advisories, duplicate dependencies
+  - Checks for license compliance, security advisories, duplicate dependencies
   - Integrated into CI pipeline
 
 - **SQLite Hook Investigation (Documented as Unsupported)**
diff --git a/lib/ecto_libsql/native.ex b/lib/ecto_libsql/native.ex
@@ -443,7 +443,7 @@ defmodule EctoLibSql.Native do
       {:ok, _} = EctoLibSql.Native.commit(state)
 
   """
-  @spec commit(EctoLibSql.State.t()) :: {:ok, EctoLibSql.State.t()} | {:error, term()}
+  @spec commit(EctoLibSql.State.t()) :: {:ok, String.t()} | {:error, term()}
   def commit(
         %EctoLibSql.State{conn_id: conn_id, trx_id: trx_id, mode: mode, sync: syncx} = _state
       ) do
@@ -460,7 +460,7 @@ defmodule EctoLibSql.Native do
       {:ok, _} = EctoLibSql.Native.rollback(state)
 
   """
-  @spec rollback(EctoLibSql.State.t()) :: {:ok, EctoLibSql.State.t()} | {:error, term()}
+  @spec rollback(EctoLibSql.State.t()) :: {:ok, String.t()} | {:error, term()}
   def rollback(
         %EctoLibSql.State{conn_id: conn_id, trx_id: trx_id, mode: mode, sync: syncx} = _state
       ) do
@@ -503,17 +503,28 @@ defmodule EctoLibSql.Native do
     String.downcase(first_word)
   end
 
+  # DML commands - data manipulation.
   defp command_atom("select"), do: :select
   defp command_atom("insert"), do: :insert
   defp command_atom("update"), do: :update
   defp command_atom("delete"), do: :delete
+
+  # Transaction control commands.
   defp command_atom("begin"), do: :begin
   defp command_atom("commit"), do: :commit
-  defp command_atom("create"), do: :create
   defp command_atom("rollback"), do: :rollback
+
+  # DDL commands - schema modifications are grouped under :create since they
+  # all modify database structure rather than data, and don't require distinct
+  # handling in result processing.
+  defp command_atom("create"), do: :create
   defp command_atom("drop"), do: :create
   defp command_atom("alter"), do: :create
+
+  # SQLite-specific.
   defp command_atom("pragma"), do: :pragma
+
+  # Catch-all for unrecognised commands.
   defp command_atom(_), do: :unknown
 
   @doc """
diff --git a/test/ecto_libsql_test.exs b/test/ecto_libsql_test.exs
@@ -185,10 +185,8 @@ defmodule EctoLibSqlTest do
       select_execute =
         EctoLibSql.handle_execute(query_select, ["nosync@gmail.com"], [], remote_state)
 
-      assert {:ok, _query,
-              %EctoLibSql.Result{command: :select, columns: [], rows: [], num_rows: 0},
-              _state} =
-               select_execute
+      assert {:ok, _query, result, _state} = select_execute
+      assert %EctoLibSql.Result{command: :select, columns: [], rows: [], num_rows: 0} = result
     end
   end
 
