Add comprehensive tests for map/list default value handling

ocean · ocean · commit c1b2f38efc6f · 2026-01-15T21:58:39.000+11:00
- Add tests for map defaults with JSON encoding
- Add tests for list defaults with JSON encoding
- Add tests for empty map and list defaults
- Add tests for complex nested map defaults
- Add tests for maps with various JSON types (string, number, bool, null)
- Update existing empty map/list tests to reflect new behavior
- All 43 migration tests + 54 connection tests pass
diff --git a/lib/ecto/adapters/libsql/connection.ex b/lib/ecto/adapters/libsql/connection.ex
@@ -473,6 +473,21 @@ defmodule Ecto.Adapters.LibSql.Connection do
   defp column_default(value) when is_binary(value), do: " DEFAULT '#{escape_string(value)}'"
   defp column_default(value) when is_number(value), do: " DEFAULT #{value}"
   defp column_default({:fragment, expr}), do: " DEFAULT #{expr}"
+
+  defp column_default(value) when is_map(value) do
+    case Jason.encode(value) do
+      {:ok, json} -> " DEFAULT '#{escape_string(json)}'"
+      {:error, _} -> ""
+    end
+  end
+
+  defp column_default(value) when is_list(value) do
+    case Jason.encode(value) do
+      {:ok, json} -> " DEFAULT '#{escape_string(json)}'"
+      {:error, _} -> ""
+    end
+  end
+
   # Handle any other unexpected types (e.g., empty maps or third-party migrations)
   # Logs a warning to help with debugging while gracefully falling back to no DEFAULT clause
   defp column_default(unexpected) do
diff --git a/test/ecto_migration_test.exs b/test/ecto_migration_test.exs
@@ -939,28 +939,30 @@ defmodule Ecto.Adapters.LibSql.MigrationTest do
     test "handles unexpected types gracefully (empty map)" do
       # This test verifies the catch-all clause for unexpected types.
       # Empty maps can come from some migrations or other third-party code.
+      # As of the defaults update, empty maps are JSON encoded like other maps.
       table = %Table{name: :users, prefix: nil}
       columns = [{:add, :metadata, :string, [default: %{}]}]
 
       # Should not raise FunctionClauseError.
       [sql] = Connection.execute_ddl({:create, table, columns})
 
-      # Empty map should be treated as no default.
-      assert sql =~ ~r/"metadata".*TEXT/
-      refute sql =~ ~r/"metadata".*DEFAULT/
+      # Empty map should be JSON encoded to '{}'
+      assert sql =~ ~r/"metadata".*TEXT.*DEFAULT/
+      assert sql =~ "'{}'"
     end
 
     test "handles unexpected types gracefully (list)" do
       # Lists are another unexpected type that might appear.
+      # As of the defaults update, lists are JSON encoded.
       table = %Table{name: :users, prefix: nil}
       columns = [{:add, :tags, :string, [default: []]}]
 
       # Should not raise FunctionClauseError.
       [sql] = Connection.execute_ddl({:create, table, columns})
 
-      # Empty list should be treated as no default.
-      assert sql =~ ~r/"tags".*TEXT/
-      refute sql =~ ~r/"tags".*DEFAULT/
+      # Empty list should be JSON encoded to '[]'
+      assert sql =~ ~r/"tags".*TEXT.*DEFAULT/
+      assert String.contains?(sql, ["DEFAULT '[]'"])
     end
 
     test "handles unexpected types gracefully (atom)" do
@@ -975,6 +977,79 @@ defmodule Ecto.Adapters.LibSql.MigrationTest do
       assert sql =~ ~r/"status".*TEXT/
       refute sql =~ ~r/"status".*DEFAULT/
     end
+
+    test "handles map defaults (JSON encoding)" do
+      table = %Table{name: :users, prefix: nil}
+
+      columns = [
+        {:add, :preferences, :text, [default: %{"theme" => "dark", "notifications" => true}]}
+      ]
+
+      [sql] = Connection.execute_ddl({:create, table, columns})
+
+      # Map should be JSON encoded
+      assert sql =~ ~r/"preferences".*TEXT.*DEFAULT/
+      assert sql =~ "theme"
+      assert sql =~ "dark"
+    end
+
+    test "handles list defaults (JSON encoding)" do
+      table = %Table{name: :items, prefix: nil}
+
+      columns = [
+        {:add, :tags, :text, [default: ["tag1", "tag2", "tag3"]]}
+      ]
+
+      [sql] = Connection.execute_ddl({:create, table, columns})
+
+      # List should be JSON encoded
+      assert sql =~ ~r/"tags".*TEXT.*DEFAULT/
+      assert sql =~ "tag1"
+      assert sql =~ "tag2"
+    end
+
+    test "handles empty list defaults" do
+      table = %Table{name: :items, prefix: nil}
+      columns = [{:add, :tags, :text, [default: []]}]
+
+      # Empty list encodes to "[]" in JSON
+      [sql] = Connection.execute_ddl({:create, table, columns})
+
+      # Should have a DEFAULT clause with empty array JSON
+      assert sql =~ ~r/"tags".*TEXT.*DEFAULT '\[\]'/
+    end
+
+    test "handles complex nested map defaults" do
+      table = %Table{name: :configs, prefix: nil}
+
+      columns = [
+        {:add, :settings, :text,
+         [default: %{"user" => %{"theme" => "light"}, "privacy" => false}]}
+      ]
+
+      [sql] = Connection.execute_ddl({:create, table, columns})
+
+      # Nested map should be JSON encoded
+      assert sql =~ ~r/"settings".*TEXT.*DEFAULT/
+      assert sql =~ "user"
+      assert sql =~ "theme"
+      assert sql =~ "light"
+    end
+
+    test "handles map with various JSON types" do
+      table = %Table{name: :data, prefix: nil}
+
+      columns = [
+        {:add, :metadata, :text,
+         [default: %{"string" => "value", "number" => 42, "bool" => true, "null" => nil}]}
+      ]
+
+      [sql] = Connection.execute_ddl({:create, table, columns})
+
+      assert sql =~ ~r/"metadata".*TEXT.*DEFAULT/
+      # Verify JSON is properly escaped
+      assert String.contains?(sql, ["string", "number", "bool"])
+    end
   end
 
   describe "CHECK constraints" do
