Skip to content

feat: unified credential access dialog and always-visible connect button#138

Merged
guyb1 merged 1 commit intomainfrom
feat/manage-access-dialog
Mar 31, 2026
Merged

feat: unified credential access dialog and always-visible connect button#138
guyb1 merged 1 commit intomainfrom
feat/manage-access-dialog

Conversation

@guyb1
Copy link
Copy Markdown
Contributor

@guyb1 guyb1 commented Mar 31, 2026

Summary

  • ManageAccessDialog: Rename ManageSecretsDialog to ManageAccessDialog, extending it to manage both secrets and app connections per agent. In selective mode, the dialog shows two sections (Secrets + App connections) with checkboxes, shared search, and combined count.
  • Agent-app-connection assignment: Add getAgentAppConnections and updateAgentAppConnections service functions and server actions with audit logging.
  • Always-visible connect button: The "Connect {App}" button on app detail pages now always shows when not connected, even without default credentials configured. Clicking it opens the connect popup which handles the BYOC flow.

Test plan

  • pnpm check passes (lint, types, format)
  • Agent card shows combined count ("2 secrets, 1 app" or "All credentials")
  • "Manage access" dropdown item opens the unified dialog
  • Selective mode shows secrets and app connections with checkboxes
  • Saving selective mode persists both secret and app connection assignments
  • Gateway only injects selected credentials for agents in selective mode
  • Connect button visible on app detail page even without default credentials

- Rename ManageSecretsDialog to ManageAccessDialog, extending it to
  manage both secrets and app connections per agent in selective mode
- Add service functions and server actions for agent-app-connection
  assignment (getAgentAppConnections, updateAgentAppConnections)
- Always show the Connect button on app detail pages, even when no
  default credentials are configured
@guyb1 guyb1 merged commit 0b20830 into main Mar 31, 2026
1 check passed
@guyb1 guyb1 deleted the feat/manage-access-dialog branch March 31, 2026 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant