Make hasher throw Runtime Exception instead of silently catching the NoSuchAlgorithmException

onlyskin · onlyskin · commit 111a27568839 · 2018-01-12T12:03:58.000+02:00
diff --git a/src/main/java/httpserver/Hasher.java b/src/main/java/httpserver/Hasher.java
@@ -14,8 +14,7 @@ public String getHash(byte[] input) {
             byte[] hash = messageDigest.digest(input);
             return bytesToHex(hash);
         } catch (NoSuchAlgorithmException e) {
-            System.out.println("Unable to get hash.");
-            return "";
+            throw new RuntimeException(e);
         }
     }
 

Original file line number	Diff line number	Diff line change
`@@ -14,8 +14,7 @@ public String getHash(byte[] input) {`
`14`	`14`	`byte[] hash = messageDigest.digest(input);`
`15`	`15`	`return bytesToHex(hash);`
`16`	`16`	`} catch (NoSuchAlgorithmException e) {`
`17`		`- System.out.println("Unable to get hash.");`
`18`		`- return "";`
	`17`	`+ throw new RuntimeException(e);`
`19`	`18`	`}`
`20`	`19`	`}`
`21`	`20`