Update Logger to throw Runtime Exception when created if it can't create the logfile

onlyskin · onlyskin · commit 3e750d35c426 · 2018-01-12T13:45:32.000+02:00
diff --git a/src/main/java/httpserver/Logger.java b/src/main/java/httpserver/Logger.java
@@ -11,7 +11,7 @@ public class Logger {
     private final Path logPath;
     private final PrintStream errorStream;
 
-    public Logger(Path logPath, FileOperator fileOperator, PrintStream errorStream) throws IOException {
+    public Logger(Path logPath, FileOperator fileOperator, PrintStream errorStream) {
         this.fileOperator = fileOperator;
         this.logPath = logPath;
         this.errorStream = errorStream;
@@ -30,7 +30,9 @@ public void log(String logString) {
     private void createFileIfDoesntExist(Path path) {
         try {
             fileOperator.createFileAtPath(path);
-        } catch (IOException e) { }
+        } catch (IOException e) {
+            throw new RuntimeException(e);
+        }
     }
 
     public byte[] readLog() throws IOException {
diff --git a/src/test/java/httpserver/LoggerTest.java b/src/test/java/httpserver/LoggerTest.java
@@ -21,11 +21,13 @@ public class LoggerTest {
     private final Path logPath;
     private final Logger logger;
     private final PrintStream printStreamMock;
+    private final FileOperator fileOperatorMock;
 
     public LoggerTest() throws IOException {
         logPath = Paths.get(tempDir().toString(), "logs");
         printStreamMock = mock(PrintStream.class);
         logger = new Logger(logPath, new FileOperator(), printStreamMock);
+        fileOperatorMock = mock(FileOperator.class);
     }
 
     @Test
@@ -50,12 +52,18 @@ public void writesToLogAndReadsFromLog() throws Exception {
 
     @Test
     public void printsErrorToStdErrIfCantWriteToLog() throws Exception {
-        FileOperator fileOperatorMock = mock(FileOperator.class);
         doThrow(new IOException()).when(fileOperatorMock).appendToFile(any(), any());
         Logger logger = new Logger(logPath, fileOperatorMock, printStreamMock);
 
         logger.log("");
 
         verify(printStreamMock).print(any(Exception.class));
     }
+
+    @Test(expected = RuntimeException.class)
+    public void throwsRuntimeExceptionIfCantCreateLogFile() throws Exception {
+        doThrow(new IOException()).when(fileOperatorMock).createFileAtPath(any());
+
+        Logger logger = new Logger(logPath, fileOperatorMock, printStreamMock);
+    }
 }
