TDD logger behaviour

onlyskin · onlyskin · commit 95a46b3a19c2 · 2017-12-07T18:37:22.000+02:00
diff --git a/src/main/java/httpserver/Logger.java b/src/main/java/httpserver/Logger.java
@@ -0,0 +1,28 @@
+package httpserver;
+
+import httpserver.file.FileOperator;
+
+import java.io.IOException;
+import java.nio.file.Path;
+
+public class Logger {
+    private final FileOperator fileOperator;
+    private final Path logPath;
+
+    public Logger(Path logPath, FileOperator fileOperator) {
+        this.fileOperator = fileOperator;
+        this.logPath = logPath;
+        createFileIfDoesntExist(logPath);
+    }
+
+    public void log(String logString) throws IOException {
+        byte[] logBytes = (logString + "\r\n").getBytes();
+        fileOperator.appendToFile(logPath, logBytes);
+    }
+
+    private void createFileIfDoesntExist(Path path) {
+        try {
+            fileOperator.createFileAtPath(path);
+        } catch (IOException e) {}
+    }
+}
diff --git a/src/main/java/httpserver/file/FileOperator.java b/src/main/java/httpserver/file/FileOperator.java
@@ -9,28 +9,16 @@
 import static java.nio.file.Files.write;
 
 public class FileOperator {
-    public void createFileAtPath(Path path) {
-        try {
-            createFile(path);
-        } catch (IOException e) {
-            e.printStackTrace();
-        }
+    public void createFileAtPath(Path path) throws IOException {
+        createFile(path);
     }
 
-    public void deleteFileAtPath(Path path) {
-        try {
-            deleteIfExists(path);
-        } catch (IOException e) {
-            e.printStackTrace();
-        }
+    public void deleteFileAtPath(Path path) throws IOException {
+        deleteIfExists(path);
     }
 
-    public void appendToFile(Path path, byte[] contents) {
-        try {
-            write(path, contents, StandardOpenOption.APPEND);
-        } catch (IOException e) {
-            e.printStackTrace();
-        }
+    public void appendToFile(Path path, byte[] contents) throws IOException {
+        write(path, contents, StandardOpenOption.APPEND);
     }
 
     public void replaceContents(Path path, byte[] contents) {
diff --git a/src/test/java/httpserver/LoggerTest.java b/src/test/java/httpserver/LoggerTest.java
@@ -0,0 +1,44 @@
+package httpserver;
+
+import httpserver.file.FileOperator;
+import org.junit.Test;
+
+import java.io.File;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.nio.file.StandardOpenOption;
+
+import static httpserver.file.FileHelpers.tempDir;
+import static java.nio.file.Files.readAllBytes;
+import static java.nio.file.Files.write;
+import static java.nio.file.Files.exists;
+import static org.junit.Assert.*;
+
+public class LoggerTest {
+    @Test
+    public void createsLogFileOnConstructDoesntOverwrite() throws Exception {
+        Path logPath = Paths.get(tempDir().toString(), "logs");
+
+        new Logger(logPath, new FileOperator());
+
+        assertTrue(exists(logPath));
+
+        write(logPath, "fake log line\r\n".getBytes(),
+                StandardOpenOption.APPEND);
+
+        new Logger(logPath, new FileOperator());
+
+        assertEquals("fake log line\r\n", new String(readAllBytes(logPath)));
+    }
+
+    @Test
+    public void onLogCallsFileOperatorAppendWithPathAndPayload() throws Exception {
+        Path logPath = Paths.get(tempDir().toString(), "logs");
+        Logger logger = new Logger(logPath, new FileOperator());
+
+        logger.log("POST example");
+        logger.log("HEAD example");
+
+        assertEquals("POST example\r\nHEAD example\r\n", new String(readAllBytes(logPath)));
+    }
+}
diff --git a/src/test/java/httpserver/file/FileOperatorTest.java b/src/test/java/httpserver/file/FileOperatorTest.java
@@ -14,11 +14,10 @@
 public class FileOperatorTest {
 
     private final Path path;
-    private final Path dir;
     private FileOperator fileOperator;
 
     public FileOperatorTest() throws IOException {
-        dir = tempDir();
+        Path dir = tempDir();
         path = Paths.get(dir.toString(), "/example.txt");
         fileOperator = new FileOperator();
     }
