why import here

Lars Solberg · Lars Solberg · commit d4d7e7459cf9 · 2020-04-11T22:14:10.000+02:00
diff --git a/api/data/opa/core/plugin.py b/api/data/opa/core/plugin.py
@@ -353,6 +353,17 @@ def _get_plugindata():
             continue
 
         logging.info(f'Loading plugin: {plugin.name}')
+
+        """
+        We should consider using lazy-loading instead of import_module.
+        This line imports all .py files, which is problematic for example for tasks.
+        If you import tasks inside an __init__, you will still need a get_component at
+        top of tasks (to mark function as celery tasks). The get_component('celery') won't
+        return anything, since everything is not ready yet.
+
+        Refactoring this code will probably be a no-go since there are many dependencies
+        in eg the hooking system. Modules needs to be loaded
+        """
         mod = import_module(plugin.name)
 
         if tasks_candidate:
@@ -430,7 +441,7 @@ def get_plugin_manager() -> PluginManager:
 
 def get_component(name: str):
     try:
-    return plugin_manager.optional_components[name]
+        return plugin_manager.optional_components[name]
     except KeyError:
         raise Exception(
             f'Component is not defined (yet?). Defined components are: {list(plugin_manager.optional_components.keys())}'
