Merge branch 'a11y-create-event' of Arnei/opencast-admin-interface into develop

gregorydlogan · gregorydlogan · commit 7f267d68abf4 · 2026-04-13T11:44:02.000-06:00
Pull request #1560 Fixing more a11y issues in the create event dialog
diff --git a/src/components/events/partials/ModalTabsAndPages/NewSourcePage.tsx b/src/components/events/partials/ModalTabsAndPages/NewSourcePage.tsx
@@ -269,10 +269,10 @@ const Upload = <T extends RequiredFormPropsUpload>({
 									formik.values.uploadAssetsTrack.map((asset, key) => (
 										<tr key={key}>
 											<td>
-												<span className="title">
+												<span id={`asset-title-${asset.id}`} className="title">
 													{translateOverrideFallback(asset, t, "SHORT")}
 												</span>
-												<p>
+												<p id={`asset-desc-${asset.id}`}>
 													{translateOverrideFallback(asset, t, "DETAIL")}
 												</p>
 											</td>
@@ -310,6 +310,9 @@ const Upload = <T extends RequiredFormPropsUpload>({
 														onChange={e =>
 															handleChange(e, `uploadAssetsTrack.${key}.file`)
 														}
+														tabIndex={0}
+														aria-labelledby={`asset-title-${asset.id}`}
+														aria-describedby={`asset-desc-${asset.id}`}
 													/>
 												</div>
 											</td>
@@ -324,6 +327,7 @@ const Upload = <T extends RequiredFormPropsUpload>({
 														);
 														(document.getElementById(asset.id) as HTMLInputElement).value = "";
 													}}
+													aria-label={t("EVENTS.EVENTS.NEW.SOURCE.UPLOAD.ARIA_REMOVE_FILE")}
 												>
 													<LuCircleX />
 												</ButtonLikeAnchor>
diff --git a/src/components/shared/modals/ResourceDetailsAccessPolicyTab.tsx b/src/components/shared/modals/ResourceDetailsAccessPolicyTab.tsx
@@ -673,6 +673,7 @@ export const AccessPolicyTable = <T extends AccessPolicyTabFormikProps>({
 																				arrayHelpers.remove(formik.values.policies.findIndex(p => p === policy))
 																			}
 																			className="action-cell-button remove"
+																			aria-label={t("EVENTS.EVENTS.DETAILS.ACCESS.ROLES.ARIA_REMOVE_ROLE")}
 																		>
 																			<LuCircleX />
 																		</ButtonLikeAnchor>
diff --git a/src/i18n/org/opencastproject/adminui/languages/lang-en_US.json b/src/i18n/org/opencastproject/adminui/languages/lang-en_US.json
@@ -549,7 +549,8 @@
 						"SUBTITLES": {
 							"SHORT": "Subtitles",
 							"DETAIL": "A subtitle file in vtt format"
-						}
+						},
+						"ARIA_REMOVE_FILE": "Remove uploaded file"
 					},
 					"DATE_TIME": {
 						"CAPTION": "Schedule",
@@ -920,7 +921,8 @@
 						"SANITIZATION_NOTE": "User role sanitization is enabled in your Opencast, therefore user roles are displayed alongside other roles. This does not impact role functionality in any way."
 					},
 					"ROLES": {
-						"LABEL": "Select or create a role"
+						"LABEL": "Select or create a role",
+						"ARIA_REMOVE_ROLE": "Remove this role"
 					}
 				},
 				"COMMENTS": {

Original file line number	Diff line number	Diff line change
`@@ -673,6 +673,7 @@ export const AccessPolicyTable = <T extends AccessPolicyTabFormikProps>({`
`673`	`673`	`arrayHelpers.remove(formik.values.policies.findIndex(p => p === policy))`
`674`	`674`	`}`
`675`	`675`	`className="action-cell-button remove"`
	`676`	`+ aria-label={t("EVENTS.EVENTS.DETAILS.ACCESS.ROLES.ARIA_REMOVE_ROLE")}`
`676`	`677`	`>`
`677`	`678`	`<LuCircleX />`
`678`	`679`	`</ButtonLikeAnchor>`