Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: openstack/cyborg
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: openstack/cyborg
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: stable/2025.1
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 10 commits
  • 22 files changed
  • 6 contributors

Commits on Feb 17, 2026

  1. Add support for pyproject.toml and wsgi module paths

    pip 23.1 removed the "setup.py install" fallback for projects that do
    not have pyproject.toml and now uses a pyproject.toml which is vendored
    in pip [1][2]. pip 24.2 has now deprecated a similar fallback to
    "setup.py develop" and plans to fully remove this in pip 25.0 [3][4][5].
    pbr supports editable installs since 6.0.0
    
    pip 25.1 has now been released and the removal is complete.
    by adding our own minimal pyproject.toml to ensure we are using the
    correct build system.
    
    This change also requires that we adapt how we generate our wsgi
    entry point. when pyproject.toml is used the wsgi console script is
    not generated in an editbale install such as is used in devstck
    
    To adress this we need to refactor our usage of our wsgi applciation
    to use a module path instead. This change does not remove
    the declaration of our wsgi_script entry point but it shoudl
    be considered deprecated and it will be removed in the future.
    
    To unblock the gate the devstack plugin is modifed to to deploy
    using the wsgi module instead of the console script.
    
    [1] https://pip.pypa.io/en/stable/news/#v23-1
    [2] pypa/pip#8368
    [3] https://pip.pypa.io/en/stable/news/#v24-2
    [4] pypa/pip#11457
    [5] https://ichard26.github.io/blog/2024/08/whats-new-in-pip-24.2/
    Closes-Bug: #2109583
    
    Note:
    - It switches python_requires to 3.9 in setup.cfg for 2025.1
      to fix the job.
    - pin setuptools to the last version to support pkg_resources to fix tox
      job
    
    Depends-On: https://review.opendev.org/c/openstack/requirements/+/976903
    
    Change-Id: I31fb6bff75ce27aedd94f7f73b7bfdd706127fc2
    (cherry picked from commit 3724b46)
    Signed-off-by: Chandan Kumar (raukadah) <[email protected]>
    SeanMooney authored and chkumar246 committed Feb 17, 2026
    Configuration menu
    Copy the full SHA
    640a4da View commit details
    Browse the repository at this point in the history
  2. [stable-only] Update .gitreview for stable/2025.1

    Change-Id: I6155f84db961dd2f1711dfacc3473b18becf94a3
    Signed-off-by: Sean Mooney <[email protected]>
    openstackadmin authored and SeanMooney committed Feb 17, 2026
    Configuration menu
    Copy the full SHA
    e91cfe0 View commit details
    Browse the repository at this point in the history
  3. [stable-only] Update TOX_CONSTRAINTS_FILE for stable/2025.1

    Update the URL to the upper-constraints file to point to the redirect
    rule on releases.openstack.org so that anyone working on this branch
    will switch to the correct upper-constraints list automatically when
    the requirements repository branches.
    
    Until the requirements repository has as stable/2025.1 branch, tests will
    continue to use the upper-constraints list on master.
    
    Change-Id: Ia320e3c5ddd5ff207e4af907c125f4bba035e989
    Signed-off-by: Sean Mooney <[email protected]>
    openstackadmin authored and SeanMooney committed Feb 17, 2026
    Configuration menu
    Copy the full SHA
    3c111ac View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2026

  1. Fix check-cherry-picks.sh for numeric stable branches

    The branch regex `stable/[a-z]+` fails to match numeric versioned
    stable branches such as `stable/2025.2`, causing the pep8 CI job
    to fail when a cherry-pick hash is legitimately present on such a
    branch.
    
    Bring the script into parity with Nova's upstream version:
    
    - Fix the regex: `[a-z]+` -> `[a-z0-9.]+` so numeric stable
      branches (e.g. stable/2025.2) are accepted.
    - Add `unmaintained/[a-z0-9.]+` as a valid branch prefix.
    - Add an EOL tag fallback via `git tag --contains` for commits
      that only exist on an EOL'd branch.
    - Add a bot-commit filter to skip validation for changes authored
      by [email protected].
    - Update the .gitreview defaultbranch check to accept unmaintained/
      branches in addition to stable/.
    - Remove the DISABLE_CHERRY_PICK_CHECK escape hatch (dropped
      upstream in Nova).
    
    Note: https://review.opendev.org/c/openstack/cyborg/+/982665 is squashed
    into this commit.
    
    Assisted-By: claude-code sonnet 4.6
    Change-Id: I9c9f1d2dd18142cebd08778d7679165fed36b4de
    Signed-off-by: Sean Mooney <[email protected]>
    (cherry picked from commit 527f218)
    (cherry picked from commit 336d5ea)
    (cherry picked from commit c4ecd6c)
    (cherry picked from commit 02be97e)
    (cherry picked from commit 84de2d0)
    SeanMooney authored and chkumar246 committed Apr 8, 2026
    Configuration menu
    Copy the full SHA
    f7c2170 View commit details
    Browse the repository at this point in the history
  2. Use common_checks.check_policy_json from oslo.upgradecheck

    The hand-rolled _check_policy_json in cyborg-status fails with
    NoSuchOptError because oslo_policy config options are never
    registered. Replace it with common_checks.check_policy_json
    from oslo.upgradecheck[1] which handles option registration
    internally.
    
    [1] https://review.opendev.org/c/openstack/oslo.upgradecheck/+/763484
    
    Closes-Bug: #2143734
    
    Generated-By: Cursor(claude-4.6-opus)
    
    Note: It addresses the merge conflicts occured during cherry-pick.
    
    Change-Id: Id2f06cb5a2abb783340a9805c07d08d723f77de2
    Signed-off-by: Chandan Kumar (raukadah) <[email protected]>
    (cherry picked from commit cf87491)
    (cherry picked from commit 904927b)
    (cherry picked from commit 01fc548)
    chkumar246 authored and SeanMooney committed Apr 8, 2026
    Configuration menu
    Copy the full SHA
    4db0234 View commit details
    Browse the repository at this point in the history
  3. Merge "Use common_checks.check_policy_json from oslo.upgradecheck" in…

    …to stable/2025.1
    Zuul authored and openstack-gerrit committed Apr 8, 2026
    Configuration menu
    Copy the full SHA
    adbf1c4 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2026

  1. Refactor session handling and align test contexts

    This change refactors database session management and aligns unit
    tests with the production DB context handling.
    
    - Replace _session_for_read() and _session_for_write() helpers with
      @main_context_manager.reader / @main_context_manager.writer decorators
      to simplify and standardize DB access.
    - Update DB API methods to use context.session directly and rely on
      centralized transaction management through enginefacade.
    - Switch tests to use cyborg.context.RequestContext instead of
      oslo_context.RequestContext for consistent context propagation.
    
    Stable-Only:
        python 3.9 and 3.12 differ in how they handel autospec when there
        are context managers that use functools.wraps
        this change was modifed to resolve that.
    
    Closes-Bug: #2061130
    Change-Id: Idf7714ec9fa57b4885bd5679f431cdeac2ad1497
    Signed-off-by: Sooyoung Kim <[email protected]>
    Signed-off-by: Sean Mooney <[email protected]>
    (cherry picked from commit 75467de)
    sykim-etri authored and SeanMooney committed Apr 22, 2026
    Configuration menu
    Copy the full SHA
    23b1ad7 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2026

  1. Use the correct package name for microversion-parse

    As of Ib97eea1037fac541c8ebadc526ae9c3bb160f685 the
    requirements check job nolonger uses pkg_resources
    to normalise the package names, this highlighted that
    we are not using the actuall name and were relying on
    that normalization for microversion-parse.
    
    This change fixes that by using the correct name.
    
    Depends-On: https://review.opendev.org/c/openstack/requirements/+/976259
    Change-Id: I25595fe1beeeb216053464ec1d36887896557fa3
    Signed-off-by: Sean Mooney <[email protected]>
    (cherry picked from commit 22d6ded)
    (cherry picked from commit 0ea86d3)
    SeanMooney committed Apr 25, 2026
    Configuration menu
    Copy the full SHA
    a301ccc View commit details
    Browse the repository at this point in the history
  2. Drop unwanted packages from test-requirements.txt

    This commit drops following unused deps:
    - ddt
    - testresources
    - testscenarios
    - tempest
    
    os-resource-classes and cursive are already defined in requirements.txt
    so dropped it from test-requirements.txt to avoid duplication.
    
    Note: It also removes reference of .testrepository in favor of stestr.
    
    Change-Id: Ic81f7ada4ebe986039ac0931e3ed032ed91feee0
    Signed-off-by: Chandan Kumar (raukadah) <[email protected]>
    (cherry picked from commit d09c782)
    (cherry picked from commit 1550ad8)
    chkumar246 authored and SeanMooney committed Apr 25, 2026
    Configuration menu
    Copy the full SHA
    0b2bb82 View commit details
    Browse the repository at this point in the history
  3. Remove deprecated get_legacy_facade usage

    The legacy enginefacade API was deprecated for nearly a decade and
    finally removed in oslo.db 18.0.0, breaking cyborg-dbsync and all
    database operations with AttributeError on get_legacy_facade.
    
    This change:
    - Replaces enginefacade.get_legacy_facade().get_engine() with the
      modern enginefacade.writer.get_engine() pattern in migration code
      and alembic env
    - Removes the unused get_session() function from api.py (all DB
      methods now use @main_context_manager decorators with context.session)
    - Updates test fixtures to use the new engine access pattern
    
    Generated-By: cursor claude opus 4.5
    Closes-Bug: #2139147
    Change-Id: I3437d66db95e82a626ed3809418e1acead47792c
    Signed-off-by: Sean Mooney <[email protected]>
    Co-authored-by: Cursor <[email protected]>
    (cherry picked from commit ef5fc87)
    (cherry picked from commit fdaeb0a)
    SeanMooney and cursoragent committed Apr 25, 2026
    Configuration menu
    Copy the full SHA
    7938466 View commit details
    Browse the repository at this point in the history
Loading