Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: openstack/hacking
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: openstack/hacking
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0.5.x
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 4 commits
  • 3 files changed
  • 4 contributors

Commits on Jun 26, 2013

  1. Include HACKING.rst in MANIFEST.in 

    Without this, I'm seeing:

  Running setup.py egg_info for package from file:///.../hacking-0.5.5.6.ga6bef44.zip
    error in setup command: Error parsing ../setup.cfg: IOError: 2

This is a "file not found" when it tries to open HACKING.rst.

Not sure whether something changed recently to cause this to start
happening.

Change-Id: I499332181c83a7bb127261efd6354ae4d92f5709
(cherry picked from commit 7c4421e)
    @markmc @fungi
    markmc authored and fungi committed Jun 26, 2013
    Configuration menu
    Copy the full SHA
    8bfdeea View commit details
    Browse the repository at this point in the history

  2. Ignore import lines with noqa 

    flake8 says that lines with '# noqa' should be ignored, but the
import rules checker isn't ignoring those lines.

This change makes it so that import lines with # noqa are ignored.

Change-Id: Icb2c3eaf0cec87e18bc3c6dcf28f8e2642ec23a2
Fixes: bug 1186188
(cherry picked from commit d728031)
    @fungi
    Brant Knudson authored and fungi committed Jun 26, 2013
    Configuration menu
    Copy the full SHA
    8f349ad View commit details
    Browse the repository at this point in the history

  3. Merge "Ignore import lines with noqa" into 0.5.x

    @openstack-gerrit
    Jenkins authored and openstack-gerrit committed Jun 26, 2013
    Configuration menu
    Copy the full SHA
    ce26036 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2019

  1. OpenDev Migration Patch 

    This commit was bulk generated and pushed by the OpenDev sysadmins
as a part of the Git hosting and code review systems migration
detailed in these mailing list posts:

http://lists.openstack.org/pipermail/openstack-discuss/2019-March/003603.html
http://lists.openstack.org/pipermail/openstack-discuss/2019-April/004920.html

Attempts have been made to correct repository namespaces and
hostnames based on simple pattern matching, but it's possible some
were updated incorrectly or missed entirely. Please reach out to us
via the contact information listed at https://opendev.org/ with any
questions you may have.
    OpenDev Sysadmins committed Apr 19, 2019
    Configuration menu
    Copy the full SHA
    dd96761 View commit details
    Browse the repository at this point in the history
Loading