Bug fixes in DTW unit tests

brunograz · brunograz · commit f7660a1dabc5 · 2016-07-22T16:16:58.000+02:00
Few modifications due typos in the code
diff --git a/mistralclient/commands/v2/delay_tolerant_workload.py b/mistralclient/commands/v2/delay_tolerant_workload.py
@@ -26,8 +26,8 @@
 LOG = logging.getLogger(__name__)
 
 
-def format_list(trigger=None):
-    return format(trigger, lister=True)
+def format_list(dtw=None):
+    return format(dtw, lister=True)
 
 
 def format(dtw=None, lister=False):
@@ -87,7 +87,7 @@ def take_action(self, parsed_args):
         mistral_client = self.app.client_manager.workflow_engine
 
         return format(mistral_client.delay_tolerant_workloads.get(
-            parsed_args.cron_trigger
+            parsed_args.delay_tolerant_workload
         ))
 
 
diff --git a/mistralclient/tests/unit/v2/test_cli_delay_tolerant_workloads.py b/mistralclient/tests/unit/v2/test_cli_delay_tolerant_workloads.py
@@ -46,12 +46,12 @@ def test_create(self, mock_open):
         result = self.call(
             delay_tolerant_cmd.Create,
             app_args=['dtw_test', 'flow1', '--deadline', '2016-07-22T00:00:00',
-                      '--params', '{}', '--job-duration', 4]
+                      '--params', '{}', '--job-duration', '4']
         )
 
         self.assertEqual(
             (
-                'dtw_test', 'flow1', '2016-07-22T00:00:00', {}, 4, '1', '1'
+                'dtw_test', 'flow1', {}, '2016-07-22T00:00:00', 4, '1', '1'
             ),
             result[1]
         )
@@ -63,7 +63,7 @@ def test_list(self):
 
         self.assertEqual(
             [(
-                'dtw_test', 'flow1', '2016-07-22T00:00:00', {}, 4, '1', '1'
+                'dtw_test', 'flow1', {}, '2016-07-22T00:00:00', 4, '1', '1'
             )],
             result[1]
         )
@@ -75,7 +75,7 @@ def test_get(self):
 
         self.assertEqual(
             (
-                'dtw_test', 'flow1', '2016-07-22T00:00:00', {}, 4, '1', '1'
+                'dtw_test', 'flow1', {}, '2016-07-22T00:00:00', 4, '1', '1'
             ),
             result[1]
         )

Original file line number	Diff line number	Diff line change
`@@ -46,12 +46,12 @@ def test_create(self, mock_open):`
`46`	`46`	`result = self.call(`
`47`	`47`	`delay_tolerant_cmd.Create,`
`48`	`48`	`app_args=['dtw_test', 'flow1', '--deadline', '2016-07-22T00:00:00',`
`49`		`- '--params', '{}', '--job-duration', 4]`
	`49`	`+ '--params', '{}', '--job-duration', '4']`
`50`	`50`	`)`
`51`	`51`
`52`	`52`	`self.assertEqual(`
`53`	`53`	`(`
`54`		`- 'dtw_test', 'flow1', '2016-07-22T00:00:00', {}, 4, '1', '1'`
	`54`	`+ 'dtw_test', 'flow1', {}, '2016-07-22T00:00:00', 4, '1', '1'`
`55`	`55`	`),`
`56`	`56`	`result[1]`
`57`	`57`	`)`
`@@ -63,7 +63,7 @@ def test_list(self):`
`63`	`63`
`64`	`64`	`self.assertEqual(`
`65`	`65`	`[(`
`66`		`- 'dtw_test', 'flow1', '2016-07-22T00:00:00', {}, 4, '1', '1'`
	`66`	`+ 'dtw_test', 'flow1', {}, '2016-07-22T00:00:00', 4, '1', '1'`
`67`	`67`	`)],`
`68`	`68`	`result[1]`
`69`	`69`	`)`
`@@ -75,7 +75,7 @@ def test_get(self):`
`75`	`75`
`76`	`76`	`self.assertEqual(`
`77`	`77`	`(`
`78`		`- 'dtw_test', 'flow1', '2016-07-22T00:00:00', {}, 4, '1', '1'`
	`78`	`+ 'dtw_test', 'flow1', {}, '2016-07-22T00:00:00', 4, '1', '1'`
`79`	`79`	`),`
`80`	`80`	`result[1]`
`81`	`81`	`)`