fixes jmoiron#688

jmoiron · jmoiron · commit 75a7ebf246fd · 2021-01-25T18:18:20.000-05:00
The changes in jmoiron#635 changed the some of the output types of In to pointers. This takes less time but it also changed the types in the output of In in a way that I think is more aggressive than I would have preferred. I'm also not 100% convinced that using pointers to types like `int` and `string` would provide an overall performance benefit when you factor in GC. Despite that, timings did get worse: pre-change: ``` BenchmarkIn-4 3136129 376 ns/op 272 B/op 4 allocs/op BenchmarkIn1k-4 171588 6602 ns/op 19488 B/op 3 allocs/op BenchmarkIn1kInt-4 157549 7502 ns/op 19488 B/op 3 allocs/op BenchmarkIn1kString-4 155502 7604 ns/op 19488 B/op 3 allocs/op ``` post-change: ``` BenchmarkIn-4 3007132 396 ns/op 272 B/op 4 allocs/op BenchmarkIn1k-4 175978 6768 ns/op 19488 B/op 3 allocs/op BenchmarkIn1kInt-4 120422 10125 ns/op 19488 B/op 3 allocs/op BenchmarkIn1kString-4 108813 10755 ns/op 19488 B/op 3 allocs/op ``` I'd prefer to keep `[]int{..}` producing ints instead of `*int` even if it means losing ~25% of perf on these special cased functions.
diff --git a/bind.go b/bind.go
@@ -249,11 +249,11 @@ func appendReflectSlice(args []interface{}, v reflect.Value, vlen int) []interfa
 		args = append(args, val...)
 	case []int:
 		for i := range val {
-			args = append(args, &val[i])
+			args = append(args, val[i])
 		}
 	case []string:
 		for i := range val {
-			args = append(args, &val[i])
+			args = append(args, val[i])
 		}
 	default:
 		for si := 0; si < vlen; si++ {
diff --git a/sqlx_test.go b/sqlx_test.go
@@ -1852,3 +1852,43 @@ func BenchmarkRebindBuffer(b *testing.B) {
 		rebindBuff(DOLLAR, q2)
 	}
 }
+
+func TestIn130Regression(t *testing.T) {
+	t.Run("[]interface{}{}", func(t *testing.T) {
+		q, args, err := In("SELECT * FROM people WHERE name IN (?)", []interface{}{[]string{"gopher"}}...)
+		if err != nil {
+			t.Fatal(err)
+		}
+		if q != "SELECT * FROM people WHERE name IN (?)" {
+			t.Errorf("got=%v", q)
+		}
+		t.Log(args)
+		for _, a := range args {
+			switch a.(type) {
+			case string:
+				t.Log("ok: string", a)
+			case *string:
+				t.Error("ng: string pointer", a, *a.(*string))
+			}
+		}
+	})
+
+	t.Run("[]string{}", func(t *testing.T) {
+		q, args, err := In("SELECT * FROM people WHERE name IN (?)", []string{"gopher"})
+		if err != nil {
+			t.Fatal(err)
+		}
+		if q != "SELECT * FROM people WHERE name IN (?)" {
+			t.Errorf("got=%v", q)
+		}
+		t.Log(args)
+		for _, a := range args {
+			switch a.(type) {
+			case string:
+				t.Log("ok: string", a)
+			case *string:
+				t.Error("ng: string pointer", a, *a.(*string))
+			}
+		}
+	})
+}

Original file line number	Diff line number	Diff line change
`@@ -249,11 +249,11 @@ func appendReflectSlice(args []interface{}, v reflect.Value, vlen int) []interfa`
`249`	`249`	`args = append(args, val...)`
`250`	`250`	`case []int:`
`251`	`251`	`for i := range val {`
`252`		`- args = append(args, &val[i])`
	`252`	`+ args = append(args, val[i])`
`253`	`253`	`}`
`254`	`254`	`case []string:`
`255`	`255`	`for i := range val {`
`256`		`- args = append(args, &val[i])`
	`256`	`+ args = append(args, val[i])`
`257`	`257`	`}`
`258`	`258`	`default:`
`259`	`259`	`for si := 0; si < vlen; si++ {`