Skip to content

deb: when PRESERVE_ENVVARS is not set, -Z$(TARBALL_COMPRESSOR) is ignored #148

@Totktonada

Description

@Totktonada

I observed the following warning during tarantool build:

WARNING generated by debuild:
Ignoring unrecognised/malformed option: --preserve-envvar -Zxz

The debuild call is shown in the output, let's look:

Building Debian packages
-------------------------------------------------------------------
cd /build/tarantool-2.11.0~entrypoint.767.dev && \
	debuild --preserve-envvar CCACHE_DIR --prepend-path=/usr/lib/ccache \
	--preserve-envvar CI \
	--preserve-envvar TARBALL_EXTRA_ARGS --preserve-envvar  \
	-Zxz -uc -us -j8

It seems, the reason is that the --preserve-envvar option has no argument.

Look at the code keeping in the mind that PRESERVE_ENVVARS is empty:

packpack/pack/deb.mk

Lines 41 to 48 in b0b4c8e

# Pass certain set of environment variables to the debuild's
# environment.
ifneq ($(PRESERVE_ENVVARS),)
comma := ,
opt := --preserve-envvar
DEBUILD_PRESERVE_ENVVARS_OPTS := \
$(opt) $(subst $(comma), $(opt) ,$(PRESERVE_ENVVARS))
endif

packpack/pack/deb.mk

Lines 143 to 151 in b0b4c8e

@echo
@echo "-------------------------------------------------------------------"
@echo "Building Debian packages"
@echo "-------------------------------------------------------------------"
cd $(BUILDDIR)/$(PRODUCT)-$(VERSION) && \
debuild --preserve-envvar CCACHE_DIR --prepend-path=/usr/lib/ccache \
--preserve-envvar CI \
$(DEBUILD_PRESERVE_ENVVARS_OPTS) \
-Z$(TARBALL_COMPRESSOR) -uc -us $(SMPFLAGS)

It seems, this flaw doesn't actually affect the build, because xz is default anyway for modern distros.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions