Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: DocNow/diffengine
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: pallih/diffengine
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 13 commits
  • 1 file changed
  • 1 contributor

Commits on Jun 25, 2017

  1. Set log level in config file

    Defaults to INFO, both on read (to make sure that old setups without the value in config.yaml don’t fail) and generation of new config file.
    Sets the peewee logger to WARNING
    pallih committed Jun 25, 2017
    Configuration menu
    Copy the full SHA
    2b6cada View commit details
    Browse the repository at this point in the history
  2. Introduce a config parameter: urlregex

    Allows for a regex to be applied to each article url when first encountered in a feed.
    Born from noticing visir.is editing errors in headlines by changing the url.
    
    Example:
    
    http://www.visir.is/g/2017170629354/glaepagengi-i-arhusum-ogna-oryggi-almennings
    
    Changed to:
    
    http://www.visir.is/g/2017170629354/glaepagengi-i-arosum-ogna-oryggi-almennings
    
    With a regex that only captures ‘http://www.visir.is/g/2017170629354’ (which is enough for the article to be displayed) then such a change is picked up.
    
    Example config:
    
    urlregex: (.*\/g\/\d*)
    pallih committed Jun 25, 2017
    Configuration menu
    Copy the full SHA
    caf5e70 View commit details
    Browse the repository at this point in the history
  3. Stray print statement

    pallih committed Jun 25, 2017
    Configuration menu
    Copy the full SHA
    0af15f5 View commit details
    Browse the repository at this point in the history
  4. Introduce a config parameter: urlregex

    Allows for a regex to be applied to each article url when first encountered in a feed.
    Born from noticing visir.is editing errors in headlines by changing the url.
    
    Example:
    
    http://www.visir.is/g/2017170629354/glaepagengi-i-arhusum-ogna-oryggi-almennings
    
    Changed to:
    
    http://www.visir.is/g/2017170629354/glaepagengi-i-arosum-ogna-oryggi-almennings
    
    With a regex that only captures ‘http://www.visir.is/g/2017170629354’ (which is enough for the article to be displayed) then such a change is picked up.
    
    Example config:
    
    urlregex: (.*\/g\/\d*)
    pallih committed Jun 25, 2017
    Configuration menu
    Copy the full SHA
    0519f31 View commit details
    Browse the repository at this point in the history
  5. Merge branch 'master' of github.com:pallih/diffengine

    Squashing stray print statement removal commit
    pallih committed Jun 25, 2017
    Configuration menu
    Copy the full SHA
    ed2f31a View commit details
    Browse the repository at this point in the history
  6. Sleep for half a second

    Instead of one
    pallih committed Jun 25, 2017
    Configuration menu
    Copy the full SHA
    1a05306 View commit details
    Browse the repository at this point in the history
  7. Whitespace fixes

    pallih committed Jun 25, 2017
    Configuration menu
    Copy the full SHA
    dd1c982 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2017

  1. Define html_partial in config

    Prompted by visir.is returning bogus text when True:
    
    https://twitter.com/visir_diff/status/879553652842745857
    pallih committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    9bba66a View commit details
    Browse the repository at this point in the history
  2. Remove soft-hyphens.

    Prompted by visir.is inserting them in headlines:
    
    https://twitter.com/visir_diff/status/879742393389547520
    pallih committed Jun 27, 2017
    Configuration menu
    Copy the full SHA
    9c16fca View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2017

  1. Configuration menu
    Copy the full SHA
    081e932 View commit details
    Browse the repository at this point in the history
  2. Config kill_classes

    Supply a list of classes that are removed with lxml prior to readability doing it’s parsing.
    It’s messy but will suffice for now.
    Prompted because readability does not properly parse pages like this:
    
    http://bleikt.pressan.is/lesa/dottir-kallar-mommu-sina-feita-svar-modur-hennar-hefur-vakid-mikla-athygli/
    
    (It Is picking up excerpts at the bottom - with the config: ‘kill_classes: ["articles-with-excerpt”]’ then we are fine)
    pallih committed Jun 28, 2017
    Configuration menu
    Copy the full SHA
    b34476d View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2017

  1. Config drop_classes

    Similar to kill_classes, but uses lxml’s ‘drop_tag’ that drops the tag, but keeps its children and text.
    
    Currently used to collapse div in ruv_diff
    pallih committed Jun 29, 2017
    Configuration menu
    Copy the full SHA
    b42e34c View commit details
    Browse the repository at this point in the history
  2. Correct logging

    pallih committed Jun 29, 2017
    Configuration menu
    Copy the full SHA
    a3010b2 View commit details
    Browse the repository at this point in the history
Loading