Skip to content

Commit d0e4f0f

Browse files
committed
more control on logging
1 parent 208a913 commit d0e4f0f

3 files changed

Lines changed: 10 additions & 12 deletions

File tree

dummy_client.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,9 @@ def server_argument(string):
3636
help="print protocol data",
3737
)
3838
parser.add_argument(
39-
"--hide-audio",
39+
"--log-audio",
4040
action="store_true",
41-
help="do not log audio messages",
41+
help="log audio messages",
4242
)
4343

4444
return parser.parse_args()
@@ -49,13 +49,11 @@ def main():
4949

5050
args = argument_parser()
5151

52-
jc = jamulus.JamulusConnector(port=args.port, debug=args.debug, log_audio=not (args.hide_audio))
52+
jc = jamulus.JamulusConnector(port=args.port, debug=args.debug, log_audio=args.log_audio)
5353

5454
audio_values = jamulus.silent_audio(BASE_NETW_SIZE)
5555
jc.sendto(args.server, "AUDIO", audio_values)
5656

57-
audio_buffer = []
58-
5957
while True:
6058
addr, key, count, values = jc.recvfrom()
6159

dummy_server.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,9 @@ def server_argument(string):
3636
help="print protocol data",
3737
)
3838
parser.add_argument(
39-
"--hide-audio",
39+
"--log-audio",
4040
action="store_true",
41-
help="do not log audio messages",
41+
help="log audio messages",
4242
)
4343

4444
return parser.parse_args()
@@ -49,7 +49,7 @@ def main():
4949

5050
args = argument_parser()
5151

52-
jc = jamulus.JamulusConnector(port=args.port, debug=args.debug, log_audio=not (args.hide_audio))
52+
jc = jamulus.JamulusConnector(port=args.port, debug=args.debug, log_audio=args.log_audio)
5353

5454
if args.centralserver:
5555
jc.sendto(
@@ -81,8 +81,6 @@ def main():
8181
}
8282
clients_pending = []
8383

84-
audio_values = jamulus.silent_audio(BASE_NETW_SIZE)
85-
8684
while True:
8785
addr, key, count, values = jc.recvfrom()
8886

@@ -101,6 +99,7 @@ def main():
10199
{"string": "<b>Server Welcome Message:</b> This is a Test Server"},
102100
)
103101

102+
audio_values = jamulus.silent_audio(len(values["data"]))
104103
jc.sendto(addr, "AUDIO", audio_values)
105104

106105
elif key == "CHANNEL_INFOS":

jamulus.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -499,7 +499,8 @@
499499

500500

501501
class JamulusConnector:
502-
def __init__(self, host="", port=DEFAULT_PORT, debug=False, log_audio=True):
502+
def __init__(self, host="", port=DEFAULT_PORT, log=True, debug=False, log_audio=True):
503+
self.log = log
503504
self.debug = debug
504505
self.log_audio = log_audio
505506
self.host = host
@@ -847,7 +848,7 @@ def log_message(self, addr, key, count="-", length="", values=None, recv=True):
847848
recv : bool
848849
True for received / False for sent
849850
"""
850-
if key != "AUDIO" or self.log_audio:
851+
if self.log and (key != "AUDIO" or self.log_audio):
851852
output = "{} {} #{} {} ({})".format(
852853
addr,
853854
" >" if recv else "< ",

0 commit comments

Comments
 (0)