forked from sourcegraph/sourcegraph-public-snapshot
-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathcodeowners_test.go
More file actions
216 lines (192 loc) · 6.2 KB
/
codeowners_test.go
File metadata and controls
216 lines (192 loc) · 6.2 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
package database
import (
"context"
"fmt"
"testing"
"github.com/google/go-cmp/cmp"
"github.com/sourcegraph/log/logtest"
"github.com/stretchr/testify/require"
"google.golang.org/protobuf/testing/protocmp"
"github.com/sourcegraph/sourcegraph/internal/api"
"github.com/sourcegraph/sourcegraph/internal/database/dbtest"
codeownerspb "github.com/sourcegraph/sourcegraph/internal/own/codeowners/v1"
owntypes "github.com/sourcegraph/sourcegraph/internal/own/types"
"github.com/sourcegraph/sourcegraph/internal/timeutil"
"github.com/sourcegraph/sourcegraph/internal/types"
)
// createRepos is a helper to set up repos we use in this test to satisfy foreign key constraints.
// repo IDs are generated automatically, so we just specify the number we want.
func createRepos(t *testing.T, ctx context.Context, store RepoStore, numOfRepos int) {
t.Helper()
for i := 0; i < numOfRepos; i++ {
if err := store.Create(ctx, &types.Repo{
Name: api.RepoName(fmt.Sprintf("%d", i)),
}); err != nil {
t.Fatal(err)
}
}
}
func TestCodeowners_CreateUpdateDelete(t *testing.T) {
ctx := context.Background()
logger := logtest.NoOp(t)
db := NewDB(logger, dbtest.NewDB(t))
createRepos(t, ctx, db.Repos(), 6)
store := db.Codeowners()
t.Run("create new codeowners file", func(t *testing.T) {
codeowners := newCodeownersFile("*", "everyone", api.RepoID(1))
if err := store.CreateCodeownersFile(ctx, codeowners); err != nil {
t.Fatal(err)
}
})
t.Run("create codeowners duplicate error", func(t *testing.T) {
codeowners := newCodeownersFile("*", "everyone", api.RepoID(2))
if err := store.CreateCodeownersFile(ctx, codeowners); err != nil {
t.Fatal(err)
}
secondErr := store.CreateCodeownersFile(ctx, codeowners)
if secondErr == nil {
t.Fatal("expect duplicate codeowners to error")
}
require.ErrorAs(t, ErrCodeownersFileAlreadyExists, &secondErr)
})
t.Run("update codeowners file", func(t *testing.T) {
codeowners := newCodeownersFile("*", "everyone", api.RepoID(3))
if err := store.CreateCodeownersFile(ctx, codeowners); err != nil {
t.Fatal(err)
}
codeowners = newCodeownersFile("*", "notEveryone", api.RepoID(3))
if err := store.UpdateCodeownersFile(ctx, codeowners); err != nil {
t.Fatal(err)
}
})
t.Run("update non existent codeowners file", func(t *testing.T) {
codeowners := newCodeownersFile("*", "notEveryone", api.RepoID(4))
err := store.UpdateCodeownersFile(ctx, codeowners)
if err == nil {
t.Fatal("expected not found error")
}
require.ErrorAs(t, CodeownersFileNotFoundError{}, &err)
})
t.Run("delete", func(t *testing.T) {
repoID := api.RepoID(5)
codeowners := newCodeownersFile("*", "everyone", repoID)
if err := store.CreateCodeownersFile(ctx, codeowners); err != nil {
t.Fatal(err)
}
if err := store.DeleteCodeownersForRepos(ctx, 5); err != nil {
t.Fatal(err)
}
})
t.Run("delete non existent codeowners file", func(t *testing.T) {
err := store.DeleteCodeownersForRepos(ctx, 6)
if err == nil {
t.Fatal("did not return useful not found information")
}
require.ErrorAs(t, CodeownersFileNotFoundError{}, &err)
})
}
func TestCodeowners_GetListCount(t *testing.T) {
ctx := context.Background()
logger := logtest.NoOp(t)
db := NewDB(logger, dbtest.NewDB(t))
createRepos(t, ctx, db.Repos(), 2)
store := db.Codeowners()
createFile := func(file *owntypes.CodeownersFile) *owntypes.CodeownersFile {
if err := store.CreateCodeownersFile(ctx, file); err != nil {
t.Fatal(err)
}
return file
}
repo1Codeowners := createFile(newCodeownersFile("*", "person", api.RepoID(1)))
repo2Codeowners := createFile(newCodeownersFile("*", "everyone", api.RepoID(2)))
t.Run("get", func(t *testing.T) {
t.Run("not found", func(t *testing.T) {
_, err := store.GetCodeownersForRepo(ctx, api.RepoID(100))
if err == nil {
t.Fatal("expected an error")
}
require.ErrorAs(t, CodeownersFileNotFoundError{}, &err)
})
t.Run("get by repo ID", func(t *testing.T) {
got, err := store.GetCodeownersForRepo(ctx, api.RepoID(1))
if err != nil {
t.Fatal(err)
}
if diff := cmp.Diff(repo1Codeowners, got, protocmp.Transform()); diff != "" {
t.Fatal(diff)
}
})
t.Run("get by repo ID after update", func(t *testing.T) {
got, err := store.GetCodeownersForRepo(ctx, api.RepoID(2))
if err != nil {
t.Fatal(err)
}
if diff := cmp.Diff(repo2Codeowners, got, protocmp.Transform()); diff != "" {
t.Fatal(diff)
}
repo2Codeowners.UpdatedAt = timeutil.Now()
if err := store.UpdateCodeownersFile(ctx, repo2Codeowners); err != nil {
t.Fatal(err)
}
got, err = store.GetCodeownersForRepo(ctx, api.RepoID(2))
if err != nil {
t.Fatal(err)
}
if diff := cmp.Diff(repo2Codeowners, got, protocmp.Transform()); diff != "" {
t.Fatal(diff)
}
})
})
t.Run("list", func(t *testing.T) {
all := []*owntypes.CodeownersFile{repo1Codeowners, repo2Codeowners}
// List all
have, cursor, err := store.ListCodeowners(ctx, ListCodeownersOpts{})
if err != nil {
t.Fatal(err)
}
if diff := cmp.Diff(all, have, protocmp.Transform()); diff != "" {
t.Fatal(diff)
}
//require.Equal(t, all, have)
if cursor != 0 {
t.Fatal("incorrect cursor returned")
}
// List with cursor pagination
var lastCursor int32
for i := 0; i < len(all); i++ {
t.Run(fmt.Sprintf("list codeowners n#%d", i), func(t *testing.T) {
opts := ListCodeownersOpts{LimitOffset: &LimitOffset{Limit: 1}, Cursor: lastCursor}
cf, c, err := store.ListCodeowners(ctx, opts)
if err != nil {
t.Fatal(err)
}
lastCursor = c
if diff := cmp.Diff(all[i], cf[0], protocmp.Transform()); diff != "" {
t.Error(diff)
}
})
}
})
t.Run("count", func(t *testing.T) {
got, err := store.CountCodeownersFiles(ctx)
if err != nil {
t.Fatal(err)
}
require.Equal(t, int32(2), got)
})
}
// newCodeownersFile returns a simple test Codeowners file with one pattern and one owner.
func newCodeownersFile(pattern, handle string, repoID api.RepoID) *owntypes.CodeownersFile {
return &owntypes.CodeownersFile{
Contents: fmt.Sprintf("%s @%s", pattern, handle),
Proto: &codeownerspb.File{
Rule: []*codeownerspb.Rule{
{
Pattern: pattern,
Owner: []*codeownerspb.Owner{{Handle: handle}},
},
},
},
RepoID: repoID,
}
}