Migrate S104 from AstNode.

lindamartin · lindamartin · commit 9673b3753959 · 2015-07-20T18:06:51.000+02:00
diff --git a/javascript-checks/src/main/java/org/sonar/javascript/checks/TooManyLinesInFileCheck.java b/javascript-checks/src/main/java/org/sonar/javascript/checks/TooManyLinesInFileCheck.java
@@ -19,18 +19,20 @@
  */
 package org.sonar.javascript.checks;
 
+import com.google.common.collect.ImmutableList;
 import org.sonar.api.server.rule.RulesDefinition;
 import org.sonar.check.Priority;
 import org.sonar.check.Rule;
 import org.sonar.check.RuleProperty;
+import org.sonar.javascript.checks.utils.SubscriptionBaseVisitor;
+import org.sonar.javascript.model.internal.lexical.InternalSyntaxToken;
+import org.sonar.plugins.javascript.api.tree.Tree;
+import org.sonar.plugins.javascript.api.tree.lexical.SyntaxToken;
 import org.sonar.squidbridge.annotations.ActivatedByDefault;
 import org.sonar.squidbridge.annotations.SqaleConstantRemediation;
 import org.sonar.squidbridge.annotations.SqaleSubCharacteristic;
-import org.sonar.squidbridge.checks.SquidCheck;
-import org.sonar.sslr.parser.LexerlessGrammar;
 
-import com.sonar.sslr.api.AstNode;
-import com.sonar.sslr.api.GenericTokenType;
+import java.util.List;
 
 @Rule(
   key = "S104",
@@ -40,7 +42,7 @@
 @ActivatedByDefault
 @SqaleSubCharacteristic(RulesDefinition.SubCharacteristics.READABILITY)
 @SqaleConstantRemediation("1h")
-public class TooManyLinesInFileCheck extends SquidCheck<LexerlessGrammar> {
+public class TooManyLinesInFileCheck extends SubscriptionBaseVisitor {
 
   private static final int DEFAULT = 1000;
 
@@ -51,18 +53,24 @@ public class TooManyLinesInFileCheck extends SquidCheck<LexerlessGrammar> {
   public int maximum = DEFAULT;
 
   @Override
-  public void init() {
-    subscribeTo(GenericTokenType.EOF);
-  }
+  public void visitNode(Tree tree) {
+    if (!((InternalSyntaxToken) tree).isEOF()) {
+      return;
+    }
 
-  @Override
-  public void visitNode(AstNode astNode) {
-    int lines = astNode.getTokenLine();
+    SyntaxToken token = (SyntaxToken) tree;
+    int lines = token.line();
 
     if (lines > maximum) {
-      getContext().createFileViolation(this, "File \"{0}\" has {1} lines, which is greater than {2} authorized. Split it into smaller files.",
-        getContext().getFile().getName(), lines, maximum);
+      getContext().addFileIssue(this, String.format("File \"%s\" has %d lines, which is greater than %d authorized. Split it into smaller files.",
+        getContext().getFile().getName(), lines, maximum));
     }
   }
+
+  @Override
+  public List<Tree.Kind> nodesToVisit() {
+    return ImmutableList.of(Tree.Kind.TOKEN);
+  }
+
 }
 
diff --git a/javascript-checks/src/test/java/org/sonar/javascript/checks/TooManyLinesInFileCheckTest.java b/javascript-checks/src/test/java/org/sonar/javascript/checks/TooManyLinesInFileCheckTest.java
@@ -19,28 +19,26 @@
  */
 package org.sonar.javascript.checks;
 
-import org.sonar.squidbridge.checks.CheckMessagesVerifier;
 import org.junit.Test;
-import org.sonar.javascript.JavaScriptAstScanner;
+import org.sonar.javascript.checks.utils.TreeCheckTest;
 import org.sonar.squidbridge.api.SourceFile;
+import org.sonar.squidbridge.checks.CheckMessagesVerifier;
 
-import java.io.File;
-
-public class TooManyLinesInFileCheckTest {
+public class TooManyLinesInFileCheckTest extends TreeCheckTest {
 
   private TooManyLinesInFileCheck check = new TooManyLinesInFileCheck();
 
   @Test
   public void testDefault() {
-    SourceFile file = JavaScriptAstScanner.scanSingleFile(new File("src/test/resources/checks/tooManyLinesInFile.js"), check);
+    SourceFile file = scanFile("src/test/resources/checks/tooManyLinesInFile.js", check);
     CheckMessagesVerifier.verify(file.getCheckMessages())
       .noMore();
   }
 
   @Test
   public void testCustom() {
     check.maximum = 1;
-    SourceFile file = JavaScriptAstScanner.scanSingleFile(new File("src/test/resources/checks/tooManyLinesInFile.js"), check);
+    SourceFile file = scanFile("src/test/resources/checks/tooManyLinesInFile.js", check);
     CheckMessagesVerifier.verify(file.getCheckMessages())
       .next().withMessage("File \"tooManyLinesInFile.js\" has 7 lines, which is greater than 1 authorized. Split it into smaller files.")
       .noMore();
