use Array.forEach instead of Array.map where applicable for better performance

ahmadnassri · ahmadnassri · commit 2f6156d6f449 · 2015-04-11T18:52:37.000-04:00
diff --git a/src/index.js b/src/index.js
@@ -11,7 +11,7 @@ var util = require('util')
 var validate = require('har-validator')
 
 // constructor
-var HTTPSnippet = function (data, lang) {
+var HTTPSnippet = function (data) {
   var entries
   var self = this
   var input = util._extend({}, data)
@@ -28,7 +28,7 @@ var HTTPSnippet = function (data, lang) {
     }]
   }
 
-  entries.map(function (entry) {
+  entries.forEach(function (entry) {
     // add optional properties to make validation successful
     entry.request.httpVersion = entry.request.httpVersion || 'HTTP/1.1'
     entry.request.queryString = entry.request.queryString || []
@@ -43,8 +43,6 @@ var HTTPSnippet = function (data, lang) {
 
     validate.request(entry.request, function (err, valid) {
       if (!valid) {
-        debug(err)
-
         throw err
       }
 
@@ -110,7 +108,7 @@ HTTPSnippet.prototype.prepare = function (request) {
         // easter egg
         form._boundary = '---011000010111000001101001'
 
-        request.postData.params.map(function (param) {
+        request.postData.params.forEach(function (param) {
           form.append(param.name, param.value || '', {
             filename: param.fileName || null,
             contentType: param.contentType || null
diff --git a/src/targets/c/libcurl.js b/src/targets/c/libcurl.js
@@ -18,7 +18,7 @@ module.exports = function (source, options) {
     code.blank()
         .push('struct curl_slist *headers = NULL;')
 
-    headers.map(function (key) {
+    headers.forEach(function (key) {
       code.push('headers = curl_slist_append(headers, "%s: %s");', key, source.headersObj[key])
     })
 
diff --git a/src/targets/csharp/restsharp.js b/src/targets/csharp/restsharp.js
@@ -18,7 +18,7 @@ module.exports = function (source, options) {
 
   // construct headers
   if (headers.length) {
-    headers.map(function (key) {
+    headers.forEach(function (key) {
       code.push('request.AddHeader("%s", "%s");', key, source.headersObj[key])
     })
   }
diff --git a/src/targets/go/native.js b/src/targets/go/native.js
@@ -89,9 +89,10 @@ module.exports = function (source, options) {
 
   // Add headers
   if (Object.keys(source.allHeaders).length) {
-    Object.keys(source.allHeaders).map(function (key) {
+    Object.keys(source.allHeaders).forEach(function (key) {
       code.push(1, 'req.Header.Add("%s", "%s")', key, source.allHeaders[key])
     })
+
     code.blank()
   }
 
diff --git a/src/targets/java/okhttp.js b/src/targets/java/okhttp.js
@@ -59,7 +59,7 @@ module.exports = function (source, options) {
 
   // construct headers
   if (headers.length) {
-    headers.map(function (key) {
+    headers.forEach(function (key) {
       code.push(1, '.addHeader("%s", "%s")', key, source.allHeaders[key])
     })
   }
diff --git a/src/targets/java/unirest.js b/src/targets/java/unirest.js
@@ -33,7 +33,7 @@ module.exports = function (source, options) {
 
   // construct headers
   if (headers.length) {
-    headers.map(function (key) {
+    headers.forEach(function (key) {
       code.push(1, '.header("%s", "%s")', key, source.allHeaders[key])
     })
   }
diff --git a/src/targets/javascript/jquery.js b/src/targets/javascript/jquery.js
@@ -41,7 +41,7 @@ module.exports = function (source, options) {
     case 'multipart/form-data':
       code.push('var form = new FormData();')
 
-      source.postData.params.map(function (param) {
+      source.postData.params.forEach(function (param) {
         code.push('form.append(%s, %s);', JSON.stringify(param.name), JSON.stringify(param.value || param.fileName || ''))
       })
 
diff --git a/src/targets/javascript/xhr.js b/src/targets/javascript/xhr.js
@@ -30,7 +30,7 @@ module.exports = function (source, options) {
     case 'multipart/form-data':
       code.push('var data = new FormData();')
 
-      source.postData.params.map(function (param) {
+      source.postData.params.forEach(function (param) {
         code.push('data.append(%s, %s);', JSON.stringify(param.name), JSON.stringify(param.value || param.fileName || ''))
       })
 
@@ -62,7 +62,7 @@ module.exports = function (source, options) {
       .blank()
       .push('xhr.open(%s, %s);', JSON.stringify(source.method), JSON.stringify(source.fullUrl))
 
-  Object.keys(source.allHeaders).map(function (key) {
+  Object.keys(source.allHeaders).forEach(function (key) {
     code.push('xhr.setRequestHeader(%s, %s);', JSON.stringify(key), JSON.stringify(source.allHeaders[key]))
   })
 
diff --git a/src/targets/node/request.js b/src/targets/node/request.js
@@ -93,7 +93,7 @@ module.exports = function (source, options) {
 
     var url = source.url
 
-    source.cookies.map(function (cookie) {
+    source.cookies.forEach(function (cookie) {
       code.push('jar.setCookie(request.cookie("%s=%s"), "%s");', encodeURIComponent(cookie.name), encodeURIComponent(cookie.value), url)
     })
     code.blank()
diff --git a/src/targets/ocaml/cohttp.js b/src/targets/ocaml/cohttp.js
@@ -35,7 +35,7 @@ module.exports = function (source, options) {
   } else if (headers.length > 1) {
     code.push('let headers = Header.add_list (Header.init ()) [')
 
-    headers.map(function (key) {
+    headers.forEach(function (key) {
       code.push(1, '("%s", "%s");', key, source.allHeaders[key])
     })
 
diff --git a/src/targets/php/curl.js b/src/targets/php/curl.js
@@ -76,7 +76,7 @@ module.exports = function (source, options) {
 
   var curlopts = new CodeBuilder(opts.indent, '\n' + opts.indent)
 
-  curlOptions.map(function (option) {
+  curlOptions.forEach(function (option) {
     if (!~[null, undefined].indexOf(option.value)) {
       curlopts.push(util.format('%s => %s,', option.name, option.escape ? JSON.stringify(option.value) : option.value))
     }
diff --git a/src/targets/php/helpers.js b/src/targets/php/helpers.js
@@ -27,7 +27,7 @@ var convert = function (obj, indent, last_indent) {
     case '[object Array]':
       result = []
 
-      obj.map(function (item) {
+      obj.forEach(function (item) {
         result.push(convert(item, indent + indent, indent))
       })
 
diff --git a/src/targets/ruby/native.js b/src/targets/ruby/native.js
@@ -37,7 +37,7 @@ module.exports = function (source, options) {
 
   var headers = Object.keys(source.allHeaders)
   if (headers.length) {
-    headers.map(function (key) {
+    headers.forEach(function (key) {
       code.push('request["%s"] = \'%s\'', key, source.allHeaders[key])
     })
   }
diff --git a/src/targets/shell/curl.js b/src/targets/shell/curl.js
@@ -30,7 +30,7 @@ module.exports = function (source, options) {
   }
 
   // construct headers
-  Object.keys(source.headersObj).sort().map(function (key) {
+  Object.keys(source.headersObj).sort().forEach(function (key) {
     var header = util.format('%s: %s', key, source.headersObj[key])
     code.push('%s %s', opts.short ? '-H' : '--header', helpers.quote(header))
   })
diff --git a/src/targets/shell/httpie.js b/src/targets/shell/httpie.js
@@ -75,11 +75,11 @@ module.exports = function (source, options) {
   if (opts.queryParams) {
     var queryStringKeys = Object.keys(source.queryObj)
 
-    queryStringKeys.map(function (name) {
+    queryStringKeys.forEach(function (name) {
       var value = source.queryObj[name]
 
       if (util.isArray(value)) {
-        value.map(function (val) {
+        value.forEach(function (val) {
           code.push('%s==%s', name, helpers.quote(val))
         })
       } else {
@@ -89,7 +89,7 @@ module.exports = function (source, options) {
   }
 
   // construct headers
-  Object.keys(source.allHeaders).sort().map(function (key) {
+  Object.keys(source.allHeaders).sort().forEach(function (key) {
     code.push('%s:%s', key, helpers.quote(source.allHeaders[key]))
   })
 
@@ -98,7 +98,7 @@ module.exports = function (source, options) {
     if (source.postData.params && source.postData.params.length) {
       flags.push(opts.short ? '-f' : '--form')
 
-      source.postData.params.map(function (param) {
+      source.postData.params.forEach(function (param) {
         code.push('%s=%s', param.name, helpers.quote(param.value))
       })
     }
diff --git a/src/targets/shell/wget.js b/src/targets/shell/wget.js
@@ -31,7 +31,7 @@ module.exports = function (source, options) {
 
   code.push('--method %s', helpers.quote(source.method))
 
-  Object.keys(source.allHeaders).map(function (key) {
+  Object.keys(source.allHeaders).forEach(function (key) {
     var header = util.format('%s: %s', key, source.allHeaders[key])
     code.push('--header %s', helpers.quote(header))
   })

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ module.exports = function (source, options) {`
`18`	`18`
`19`	`19`	`// construct headers`
`20`	`20`	`if (headers.length) {`
`21`		`- headers.map(function (key) {`
	`21`	`+ headers.forEach(function (key) {`
`22`	`22`	`code.push('request.AddHeader("%s", "%s");', key, source.headersObj[key])`
`23`	`23`	`})`
`24`	`24`	`}`
Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ module.exports = function (source, options) {`
`59`	`59`
`60`	`60`	`// construct headers`
`61`	`61`	`if (headers.length) {`
`62`		`- headers.map(function (key) {`
	`62`	`+ headers.forEach(function (key) {`
`63`	`63`	`code.push(1, '.addHeader("%s", "%s")', key, source.allHeaders[key])`
`64`	`64`	`})`
`65`	`65`	`}`
Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ module.exports = function (source, options) {`
`33`	`33`
`34`	`34`	`// construct headers`
`35`	`35`	`if (headers.length) {`
`36`		`- headers.map(function (key) {`
	`36`	`+ headers.forEach(function (key) {`
`37`	`37`	`code.push(1, '.header("%s", "%s")', key, source.allHeaders[key])`
`38`	`38`	`})`
`39`	`39`	`}`