Permalink
Checking mergeability…
Don’t worry, you can still create the pull request.
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 4 commits
- 1 file changed
- 1 contributor
Commits on Feb 8, 2024
-
-
This does do no actual changes, but it'll make it easier to see the actual changes in subsequent commits, rather than them being obscured by formatting changes.
-
fix psc_whistler.cxx to properly handle 3 species
Usually it's best not to specify a number of populations (last argument to `setup_particles()`, so it'll automatically use the number of species (a.k.a., particle kinds). I didn't touch the `neutralizing_population`, but that may need to be fixed as well. Generally speaking, it's good practice to use named constants instead of hard coded numbers, e.g., replace "4" by "N_MY_KINDS", so it'll automatically adjust if you change the number of particle kinds used.
-
This particle type will actually carry around a unique particle id, as well as a tag. The id should be set automatically -- if you want to also give particles specific tags during initialization, one can do as demonstrated via npt.tag (for testing, I just set the tag to 10x the particle kind, which doesnt actually make much sense...)
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff main...tagging