-
Notifications
You must be signed in to change notification settings - Fork 2
Customizable root indicators #1
Copy link
Copy link
Closed
Labels
good first issueGood for newcomersGood for newcomers
Description
Given a subdirectory of e.g. a git repo, the get_root function will tell you the root of that repo. Pretty straightforward goal, and there are some tests already.
For this issue,
- Modify
get_rootto take an iterable (typing.Iterable[str]) of indicators. Using this type, list, set, and tuple should all work. - Default to the current
ROOT_INDICATORS - Add a test that shows the customization works
- Submit a PR!
Quick development instructions
git clone clone https://github.com/python-packaging/tubercd tubermake venvsource .venv/bin/activatemake test(runs unittest)
Make sure the code is formatted (make format) and types are good (make lint) before submitting a PR to save iteration time waiting on CI.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
good first issueGood for newcomersGood for newcomers