Use []byte instead of bytes.Buffer in In

nussjustin · nussjustin · commit eae951751ba1 · 2017-02-26T12:21:21.000+01:00
diff --git a/bind.go b/bind.go
@@ -136,7 +136,7 @@ func In(query string, args ...interface{}) (string, []interface{}, error) {
 	}
 
 	newArgs := make([]interface{}, 0, flatArgsCount)
-	buf := bytes.NewBuffer(make([]byte, 0, len(query)+len(", ?")*flatArgsCount))
+	buf := make([]byte, 0, len(query)+len(", ?")*flatArgsCount)
 
 	var arg, offset int
 
@@ -162,10 +162,10 @@ func In(query string, args ...interface{}) (string, []interface{}, error) {
 		}
 
 		// write everything up to and including our ? character
-		buf.WriteString(query[:offset+i+1])
+		buf = append(buf, query[:offset+i+1]...)
 
 		for si := 1; si < argMeta.length; si++ {
-			buf.WriteString(", ?")
+			buf = append(buf, ", ?"...)
 		}
 
 		newArgs = appendReflectSlice(newArgs, argMeta.v, argMeta.length)
@@ -176,13 +176,13 @@ func In(query string, args ...interface{}) (string, []interface{}, error) {
 		offset = 0
 	}
 
-	buf.WriteString(query)
+	buf = append(buf, query...)
 
 	if arg < len(meta) {
 		return "", nil, errors.New("number of bindVars less than number arguments")
 	}
 
-	return buf.String(), newArgs, nil
+	return string(buf), newArgs, nil
 }
 
 func appendReflectSlice(args []interface{}, v reflect.Value, vlen int) []interface{} {

Original file line number	Diff line number	Diff line change
`@@ -136,7 +136,7 @@ func In(query string, args ...interface{}) (string, []interface{}, error) {`
`136`	`136`	`}`
`137`	`137`
`138`	`138`	`newArgs := make([]interface{}, 0, flatArgsCount)`
`139`		`- buf := bytes.NewBuffer(make([]byte, 0, len(query)+len(", ?")*flatArgsCount))`
	`139`	`+ buf := make([]byte, 0, len(query)+len(", ?")*flatArgsCount)`
`140`	`140`
`141`	`141`	`var arg, offset int`
`142`	`142`
`@@ -162,10 +162,10 @@ func In(query string, args ...interface{}) (string, []interface{}, error) {`
`162`	`162`	`}`
`163`	`163`
`164`	`164`	`// write everything up to and including our ? character`
`165`		`- buf.WriteString(query[:offset+i+1])`
	`165`	`+ buf = append(buf, query[:offset+i+1]...)`
`166`	`166`
`167`	`167`	`for si := 1; si < argMeta.length; si++ {`
`168`		`- buf.WriteString(", ?")`
	`168`	`+ buf = append(buf, ", ?"...)`
`169`	`169`	`}`
`170`	`170`
`171`	`171`	`newArgs = appendReflectSlice(newArgs, argMeta.v, argMeta.length)`
`@@ -176,13 +176,13 @@ func In(query string, args ...interface{}) (string, []interface{}, error) {`
`176`	`176`	`offset = 0`
`177`	`177`	`}`
`178`	`178`
`179`		`- buf.WriteString(query)`
	`179`	`+ buf = append(buf, query...)`
`180`	`180`
`181`	`181`	`if arg < len(meta) {`
`182`	`182`	`return "", nil, errors.New("number of bindVars less than number arguments")`
`183`	`183`	`}`
`184`	`184`
`185`		`- return buf.String(), newArgs, nil`
	`185`	`+ return string(buf), newArgs, nil`
`186`	`186`	`}`
`187`	`187`
`188`	`188`	`func appendReflectSlice(args []interface{}, v reflect.Value, vlen int) []interface{} {`