On the post() method in the base resource there is both a data and a kwargs. Is it necessary to have these or could we just send the request data in the kwargs and remove the data part:
https://github.com/rehive/rehive-python/blob/master/rehive/api/resources/base_resources.py#L22
Investigate whether this change would cause any issues or would potentially limit other functionality in future.
One potentially nice thing is that by limiting it to the data, we could theoretically have fields that have the same field name as other kwargs that are used by the SDK (Ie. there wouldn't have to be "reserved" values). This could be a reason to in fact always support both kwargs and data as a way to allow reserved values when needed but still support the much simpler interface in most case.
On the
post()method in the base resource there is both adataand akwargs. Is it necessary to have these or could we just send the request data in thekwargsand remove thedatapart:https://github.com/rehive/rehive-python/blob/master/rehive/api/resources/base_resources.py#L22
Investigate whether this change would cause any issues or would potentially limit other functionality in future.
One potentially nice thing is that by limiting it to the
data, we could theoretically have fields that have the same field name as other kwargs that are used by the SDK (Ie. there wouldn't have to be "reserved" values). This could be a reason to in fact always support bothkwargsanddataas a way to allow reserved values when needed but still support the much simpler interface in most case.