Just exposing permission type enum until there's more to this relation than one property

kohsuke · kohsuke · commit 6bfeb54f3c51 · 2017-01-09T16:14:30.000-08:00
diff --git a/src/main/java/org/kohsuke/github/GHPermission.java b/src/main/java/org/kohsuke/github/GHPermission.java
@@ -24,11 +24,13 @@
 
 package org.kohsuke.github;
 
+import java.util.Locale;
+
 /**
  * Permission for a user in a repository.
  * @see <a href="https://developer.github.com/v3/repos/collaborators/#review-a-users-permission-level">API</a>
  */
-public class GHPermission {
+/*package*/ class GHPermission {
 
     private String permission;
     private GHUser user;
@@ -40,6 +42,10 @@ public String getPermission() {
         return permission;
     }
 
+    public GHPermissionType getPermissionType() {
+        return Enum.valueOf(GHPermissionType.class, permission.toUpperCase(Locale.ENGLISH));
+    }
+
     public GHUser getUser() {
         return user;
     }
diff --git a/src/main/java/org/kohsuke/github/GHPermissionType.java b/src/main/java/org/kohsuke/github/GHPermissionType.java
@@ -0,0 +1,11 @@
+package org.kohsuke.github;
+
+/**
+ * @author Kohsuke Kawaguchi
+ */
+public enum GHPermissionType {
+    ADMIN,
+    WRITE,
+    READ,
+    NONE
+}
diff --git a/src/main/java/org/kohsuke/github/GHRepository.java b/src/main/java/org/kohsuke/github/GHRepository.java
@@ -486,10 +486,19 @@ public Set<String> getCollaboratorNames() throws IOException {
      * @throws FileNotFoundException under some conditions (e.g., private repo you can see but are not an admin of); treat as unknown
      * @throws HttpException with a 403 under other conditions (e.g., public repo you have no special rights to); treat as unknown
      */
-    public GHPermission getPermission(String user) throws IOException {
+    public GHPermissionType getPermission(String user) throws IOException {
         GHPermission perm = root.retrieve().withHeader("Accept", "application/vnd.github.korra-preview").to(getApiTailUrl("collaborators/" + user + "/permission"), GHPermission.class);
         perm.wrapUp(root);
-        return perm;
+        return perm.getPermissionType();
+    }
+
+    /**
+     * Obtain permission for a given user in this repository.
+     * @throws FileNotFoundException under some conditions (e.g., private repo you can see but are not an admin of); treat as unknown
+     * @throws HttpException with a 403 under other conditions (e.g., public repo you have no special rights to); treat as unknown
+     */
+    public GHPermissionType getPermission(GHUser u) throws IOException {
+        return getPermission(u.getLogin());
     }
 
     /**
