Merge pull request piotrmurach#195 from reenhanced/master

piotrmurach · piotrmurach · commit 4db21ef5229e · 2014-10-25T19:04:42.000+01:00
Send correctly formatted Authorization header to github when OAUTH token is present
diff --git a/lib/github_api/request/oauth2.rb b/lib/github_api/request/oauth2.rb
@@ -18,7 +18,7 @@ def call(env)
 
         if token = params[ACCESS_TOKEN] and !token.empty?
           env[:url].query = build_query params
-          env[:request_headers].merge!(AUTH_HEADER => "Token token=\"#{token}\"")
+          env[:request_headers].merge!(AUTH_HEADER => "token #{token}")
         end
 
         @app.call env
diff --git a/spec/github/request/oauth2_spec.rb b/spec/github/request/oauth2_spec.rb
@@ -40,7 +40,7 @@ def process(params={}, headers={})
 
     it "creates header for ad hoc access token" do
       result = process(:q => 'query', :access_token => 'abc123')
-      auth_header(result).should eql 'Token token="abc123"'
+      auth_header(result).should eql 'token abc123'
     end
   end
 
@@ -53,13 +53,13 @@ def process(params={}, headers={})
     end
 
     it "creates header for access token" do
-      auth_header(process).should eql 'Token token="ABC"'
+      auth_header(process).should eql 'token ABC'
     end
 
     it "overrides default with explicit token" do
       result = process(:q => 'query', :access_token => 'abc123')
       result[:url].query.should eql 'access_token=abc123&q=query'
-      auth_header(result).should eql 'Token token="abc123"'
+      auth_header(result).should eql 'token abc123'
     end
 
     it "clears default token with explicit one" do
