Merge pull request piotrmurach#192 from jcabas/clean_out_page_iterator

piotrmurach · piotrmurach · commit ae08e84e45d6 · 2014-10-25T19:09:41.000+01:00
Cleaned out page iterator class
diff --git a/lib/github_api/page_iterator.rb b/lib/github_api/page_iterator.rb
@@ -31,36 +31,31 @@ def has_next?
     end
 
     def count
-      return nil unless last_page_uri
-      parse_query(URI(last_page_uri).query)['page']
+      parse_query(URI(last_page_uri).query)['page'] if last_page_uri
     end
 
     # Perform http get request for the first resource
     #
     def first
-      return nil unless first_page_uri
-      perform_request(first_page_uri)
+      perform_request(first_page_uri) if first_page_uri
     end
 
     # Perform http get request for the next resource
     #
     def next
-      return nil unless has_next?
-      perform_request(next_page_uri)
+      perform_request(next_page_uri) if has_next?
     end
 
     # Perform http get request for the previous resource
     #
     def prev
-      return nil unless prev_page_uri
-      perform_request(prev_page_uri)
+      perform_request(prev_page_uri) if prev_page_uri
     end
 
     # Perform http get request for the last resource
     #
     def last
-      return nil unless last_page_uri
-      perform_request(last_page_uri)
+      perform_request(last_page_uri) if last_page_uri
     end
 
     # Returns the result for a specific page.
@@ -101,7 +96,6 @@ def perform_request(attribute)
     def sha(params)
       return params['last_sha'] if params.keys.include?('last_sha')
       return DEFAULT_SHA if params.keys.include?('sha')
-      nil
     end
 
     def parse_per_page_number(uri) # :nodoc:
