Hash does not respond to delete!

josacar · josacar · commit bf4318a55b75 · 2014-10-03T21:47:07.000+02:00
Also remove 2nd monkeypatch in spec_helper
diff --git a/lib/github_api/core_ext/hash.rb b/lib/github_api/core_ext/hash.rb
@@ -11,9 +11,8 @@ def except(*items)
   # Similar to except but modifies self
   #
   def except!(*keys)
-    copy = self.dup
-    keys.each { |key| copy.delete!(key) }
-    copy
+    keys.each { |key| delete(key) }
+    self
   end unless method_defined? :except!
 
   # Returns a new hash with all the keys converted to symbols
diff --git a/spec/github/core_ext/hash_spec.rb b/spec/github/core_ext/hash_spec.rb
@@ -15,6 +15,9 @@
   context '#except!' do
     it "should respond to except!" do
       @nested_hash.should respond_to :except!
+      copy = @nested_hash.dup
+      copy.except!('b', 'a')
+      copy.should be_empty
     end
   end
 
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb
@@ -99,11 +99,3 @@ def reset_authentication_for(object)
     object.send("#{item}=", nil)
   end
 end
-
-class Hash
-  def except(*keys)
-    cpy = self.dup
-    keys.each { |key| cpy.delete(key) }
-    cpy
-  end
-end
