Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rqlite/sql
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: fix-multi-join-string
Choose a base ref
...
head repository: rqlite/sql
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 3 commits
  • 4 files changed
  • 2 contributors

Commits on Feb 24, 2026

  1. Revert "Fix JoinClause.String() for 4+ joins" 

    This reverts commit 0fd9bb7.
    @otoolep
    otoolep committed Feb 24, 2026
    Configuration menu
    Copy the full SHA
    da204e4 View commit details
    Browse the repository at this point in the history

  2. Add 4+ JOIN parsing unit tests

    @otoolep
    otoolep committed Feb 24, 2026
    Configuration menu
    Copy the full SHA
    550771f View commit details
    Browse the repository at this point in the history

  3. Build left-nested AST for multi-way JOINs 

    The parser previously built a right-nested tree for multi-way JOINs,
which separated each ON constraint from its corresponding join and
required a complex writeJoinClause() helper to reassemble the correct
SQL output. This broke for 4+ joins.

Switch to left-nested trees matching SQL's left-associative semantics,
so each constraint stays with its join and String() becomes trivially
recursive.

Co-authored-by: Claude Opus 4.6 <[email protected]>
    @otoolep @claude
    otoolep and claude authored Feb 24, 2026
    Configuration menu
    Copy the full SHA
    1b2524a View commit details
    Browse the repository at this point in the history
Loading