Commits

Branch selector

 master

User selector

All users

All time

Commit History

Commits on Jun 17, 2015

• update of the findbugs lib

  Show description for 2e79207
  DaanHoogland

  committed
  2e79207

  Copy full SHA for 2e79207

Commits on Jun 16, 2015

• findbugs: better message and fallback to defaultCharset

  DaanHoogland

  committed
  41c1fdd

  Copy full SHA for 41c1fdd

• Catch encoding exception

  Show description for 0851e4e
  

  rsafonseca

  authored and

  DaanHoogland

  committed
  0851e4e

  Copy full SHA for 0851e4e

• Fix findbugs encoding issue in VmwareStorageProcessor.java Any encoding would do fine as it's just used to generate a UUID. Sticking with UTF-8 for consistency

  Show description for 9f2ebdf
  

  rsafonseca

  authored and

  DaanHoogland

  committed
  9f2ebdf

  Copy full SHA for 9f2ebdf

• Fix findbugs warning in VmwareStorageManagerImpl.java Any encoding would do fine as it's just used to generate a UUID. Sticking with UTF-8 for consistency

  Show description for 9bb920a
  

  rsafonseca

  authored and

  DaanHoogland

  committed
  9bb920a

  Copy full SHA for 9bb920a

• Fix findbugs encoding issue in VmwareResource.java Key file should be UTF-8 encoded in VR

  Show description for 3d48af4
  

  rsafonseca

  authored and

  DaanHoogland

  committed
  3d48af4

  Copy full SHA for 3d48af4

Commits on Jun 15, 2015

• Fix css syntax error in cloudstack3.css

  Show description for 6dbf476
  

  rsafonseca

  authored and

  DaanHoogland

  committed
  6dbf476

  Copy full SHA for 6dbf476

• Fix 4 findbugs warnings in JuniperSrxResource Data should be read and written in UTF-8 to the SRX Buffers were being used for reading but not for writing, PrintWriter was auto-flushing and code was…

  Show description for 34d097f
  

  rsafonseca

  authored and

  yadvr

  committed
  34d097f

  Copy full SHA for 34d097f

• Merge branch 'CLOUDSTACK-8560'

  wido

  committed
  5fe0696

  Copy full SHA for 5fe0696

• CLOUDSTACK-8560: Stat the resulting image after copying from template and return the size

  Show description for 4b4c52e
  wido

  committed
  4b4c52e

  Copy full SHA for 4b4c52e

• Fix 2 findbugs STCAL_STATIC_SIMPLE_DATE_FORMAT_INSTANCE warnings in BaseCmd.java Dateformat objects are not threadsafe and should be defined as instance variables Both INPUT_FORMAT and NEW_INPUT_FO…

  Show description for ae328a6
  

  rsafonseca

  authored and

  DaanHoogland

  committed
  ae328a6

  Copy full SHA for ae328a6

• CLOUDSTACK-8559: IP Source spoofing should not be allowed

  Show description for 3e3c11f
  wido

  committed
  3e3c11f

  Copy full SHA for 3e3c11f

• Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in UserVmJoinVO.java Assert isn't used in prod runtime

  Show description for 34a791c
  

  rsafonseca

  authored and

  yadvr

  committed
  34a791c

  Copy full SHA for 34a791c

• Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in HostVO.java Assert isn't used in prod runtime

  Show description for 874aa8d
  

  rsafonseca

  authored and

  yadvr

  committed
  874aa8d

  Copy full SHA for 874aa8d

• Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in NetworkOrchestrator.java If answer is null, method will throw ConnectionException in line 3016 as satisfied by condition stated in line 3014

  Show description for 0dc2590
  

  rsafonseca

  authored and

  yadvr

  committed
  0dc2590

  Copy full SHA for 0dc2590

• Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in EngineDataCenterVO.java Assert isn't used in prod runtime, null is checked in method

  Show description for 1b79a8e
  

  rsafonseca

  authored and

  yadvr

  committed
  1b79a8e

  Copy full SHA for 1b79a8e

• Fix findbugs RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE in AgentManagerImpl.java Assert isn't used in runtime, null is properly checked in method

  Show description for 0f4aac7
  

  rsafonseca

  authored and

  yadvr

  committed
  0f4aac7

  Copy full SHA for 0f4aac7

• Fix 3 findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING warnings in Upgrade410to420.java There was no risk of sql injection here, nor any need to use PreparedStatement, still this f…

  Show description for 117870c
  

  rsafonseca

  authored and

  yadvr

  committed
  117870c

  Copy full SHA for 117870c

• Fix findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING warning in Upgrade30xBase.java There was no risk of sql injection here, nor any need to use PreparedStatement, still, this fixe…

  Show description for 4eaa613
  

  rsafonseca

  authored and

  yadvr

  committed
  4eaa613

  Copy full SHA for 4eaa613

• Fix findbugs SQL_PREPARED_STATEMENT_GENERATED_FROM_NONCONSTANT_STRING warning in Upgrade2214to30.java There was no risk of sql injection here, nor any need to use PreparedStatement, still this fixe…

  Show description for 869cc0c
  

  rsafonseca

  authored and

  yadvr

  committed
  869cc0c

  Copy full SHA for 869cc0c

• Fix findbugs NS_DANGEROUS_NON_SHORT_CIRCUIT warning in NetworkServiceImpl.java

  Show description for 7a57ce3
  

  rsafonseca

  authored and

  yadvr

  committed
  7a57ce3

  Copy full SHA for 7a57ce3

• Remove accidental ~ character :)

  Show description for 3d1dde7
  

  rsafonseca

  authored and

  yadvr

  committed
  3d1dde7

  Copy full SHA for 3d1dde7

• Fix findbugs warning HE_EQUALS_USE_HASHCODE in Ip4Address.java When overriding equals(), hashCode() must also be overriden do comply with the directive that equal objects must have equal hashcodes …

  Show description for a670f98
  

  rsafonseca

  authored and

  yadvr

  committed
  a670f98

  Copy full SHA for a670f98

• Fix 2 findbugs warnings in ApiResponseHelper.java ints were being boxed just to call .toString()

  Show description for 1bd3286
  

  rsafonseca

  authored and

  yadvr

  committed
  1bd3286

  Copy full SHA for 1bd3286

• Fix findbugs warning in NetworkServiceImpl.java Integer was being boxed just to call toString()

  Show description for ea7f4bd
  

  rsafonseca

  authored and

  yadvr

  committed
  ea7f4bd

  Copy full SHA for ea7f4bd

• Fix findbugs warning in Script.java Unnecessary boxing/unboxing of int value

  Show description for a4659d0
  

  rsafonseca

  authored and

  yadvr

  committed
  a4659d0

  Copy full SHA for a4659d0

• Fix findbugs warning in NetUtils.java Unnecessary boxing/unboxing of primitive value

  Show description for 14f761a
  

  rsafonseca

  authored and

  yadvr

  committed
  14f761a

  Copy full SHA for 14f761a

• Fix findbugs warning in ProjectManagerImpl.java Unnecessary boxing/unboxing of primitive value

  Show description for ec28018
  

  rsafonseca

  authored and

  yadvr

  committed
  ec28018

  Copy full SHA for ec28018

• Fix findbugs warning in NetworkUsageManagerImpl.java Unnecessary boxing/unboxing of long value to create Date

  Show description for 4d31ed9
  

  rsafonseca

  authored and

  yadvr

  committed
  4d31ed9

  Copy full SHA for 4d31ed9

• Fix 2 findbugs warnings in NetworkServiceImpl.java Unnecessary boxing/unboxing of int values

  Show description for d7a27c9
  

  rsafonseca

  authored and

  yadvr

  committed
  d7a27c9

  Copy full SHA for d7a27c9

• Fix findbugs warning in CloudZonesStartupProcessor.java Unnecessary boxing/unboxing of primitive value

  Show description for e831fce
  

  rsafonseca

  authored and

  yadvr

  committed
  e831fce

  Copy full SHA for e831fce

• Fix findbugs warning in ApiDispatcher.java Unnecessary boxing/unboxing of long value

  Show description for 62e78cd
  

  rsafonseca

  authored and

  yadvr

  committed
  62e78cd

  Copy full SHA for 62e78cd

• Fix 2 findbugs warnings in ElastistorUtil.java Unnecessary boxing/unboxing of long value

  Show description for 9511831
  

  rsafonseca

  authored and

  yadvr

  committed
  9511831

  Copy full SHA for 9511831

• Fix findbugs warning in ElastistorPrimaryDataStoreLifeCycle.java Unnecessary boxing/unboxing of primitive value

  Show description for ea31a67
  

  rsafonseca

  authored and

  yadvr

  committed
  ea31a67

  Copy full SHA for ea31a67

• Fix findbugs warning in PaloAltoResource.java Unnecessary boxing/unboxing of primitive value

  Show description for 6f330f7
  

  rsafonseca

  authored and

  yadvr

  committed
  6f330f7

  Copy full SHA for 6f330f7