Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: TesterViera/JavaLibTester
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: sbloch/JavaLibTester
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 5 commits
  • 2 files changed
  • 1 contributor

Commits on Dec 29, 2012

  1. The public "runWhatever" hooks in Tester return boolean (success

    or at least one failure) rather than void.
    sbloch committed Dec 29, 2012
    Configuration menu
    Copy the full SHA
    667781b View commit details
    Browse the repository at this point in the history

Commits on Dec 31, 2012

  1. Took out special-case treatment of Canvas, WorldImage, and Tunes

    classes.
    Took out optimization that says if two objects aren't the same class,
    they can't be same().
    sbloch committed Dec 31, 2012
    Configuration menu
    Copy the full SHA
    72eaed4 View commit details
    Browse the repository at this point in the history

Commits on Jan 1, 2013

  1. Configuration menu
    Copy the full SHA
    dfc5fd4 View commit details
    Browse the repository at this point in the history
  2. Correct the list of classes in the WorldImages package.

    (Why does this need to be hard-coded into the Tester at all?)
    sbloch committed Jan 1, 2013
    Configuration menu
    Copy the full SHA
    2c4037f View commit details
    Browse the repository at this point in the history

Commits on May 22, 2013

  1. Fixed bug introduced Dec 30. When I took out the optimization that said

    "objects of different classes can't be same()", I didn't notice that
    some of the comparison code assumed both objects had already been
    confirmed to be the same class.  As a result, comparing an object of a
    class with no fields with one of a class with fields could either pass
    or crash, depending on the order.
    Fix: put back in the "if (sameClass)" test, but applying only to a
    smaller section of code, so it's still possible to override this rule
    with same().
    sbloch committed May 22, 2013
    Configuration menu
    Copy the full SHA
    8dc5742 View commit details
    Browse the repository at this point in the history
Loading