Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: scrapy-plugins/scrapy-playwright
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.0.37
Choose a base ref
...
head repository: scrapy-plugins/scrapy-playwright
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.0.38
Choose a head ref
  • 6 commits
  • 19 files changed
  • 2 contributors

Commits on Jul 3, 2024

  1. _utils._get_float_setting (#287)

    @elacuesta
    elacuesta authored Jul 3, 2024
    Configuration menu
    Copy the full SHA
    d825d6f View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2024

  1. Documentation updates: playwright_suggested_filename meta key, Page t… 

    …ype hints
    @elacuesta
    elacuesta committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    ca8cc46 View commit details
    Browse the repository at this point in the history

  2. Fix freezing on responses with status 204 (#292) 

    * Wait for download to start, raise error on 204

* Test failure on 204 status

* Logging adjustments
    @elacuesta
    elacuesta authored Jul 6, 2024
    Configuration menu
    Copy the full SHA
    55528dc View commit details
    Browse the repository at this point in the history

  3. Connect to remote browser using BrowserType.connect (#283) 

    * Connect to remote browser with BrowserType.connect

* Docs for PLAYWRIGHT_CONNECT_URL & PLAYWRIGHT_CONNECT_KWARGS

* Test error when setting PLAYWRIGHT_CDP_URL and PLAYWRIGHT_CONNECT_URL

* Rename method, simplify variables

* Test PLAYWRIGHT_CONNECT_URL

* Setup node for tests

* Test connect on Windows

* Match python & nodejs playwright versions

* Adjustments

* Update tox.ini

* Double slash
    @elacuesta
    elacuesta authored Jul 6, 2024
    Configuration menu
    Copy the full SHA
    8c6d9bb View commit details
    Browse the repository at this point in the history

  4. Update changelog for 0.0.38

    @elacuesta
    elacuesta committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    198b267 View commit details
    Browse the repository at this point in the history

  5. Bump version: 0.0.37 → 0.0.38

    @elacuesta
    elacuesta committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    ab103fe View commit details
    Browse the repository at this point in the history
Loading