Skip to content

Commit 1824597

Browse files
committed
Remove first_columns parameter
This is redundant since we're now using Airtable's metadata API
1 parent 362d57d commit 1824597

File tree

1 file changed

+2
-13
lines changed

1 file changed

+2
-13
lines changed

seatable_api/convert_airtable.py

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -495,7 +495,7 @@ def get_schema(self):
495495

496496
class AirtableConvertor(object):
497497

498-
def __init__(self, airtable_api_key, airtable_base_id, base, table_names, first_columns=[], links=[], excluded_column_types=[], excluded_columns=[]):
498+
def __init__(self, airtable_api_key, airtable_base_id, base, table_names, links=[], excluded_column_types=[], excluded_columns=[]):
499499
"""
500500
airtable_api_key: str
501501
airtable_base_id: str
@@ -508,7 +508,6 @@ def __init__(self, airtable_api_key, airtable_base_id, base, table_names, first_
508508
self.airtable_api = AirtableAPI(airtable_api_key, airtable_base_id)
509509
self.base = base
510510
self.table_names = table_names
511-
self.first_columns = first_columns
512511
self.links = links
513512
self.excluded_column_types = excluded_column_types
514513
self.excluded_columns = excluded_columns
@@ -517,7 +516,6 @@ def __init__(self, airtable_api_key, airtable_base_id, base, table_names, first_
517516
self.files_convertor = FilesConvertor(airtable_api_key, base)
518517
self.rows_convertor = RowsConvertor(self.files_convertor)
519518
self.links_convertor = LinksConvertor()
520-
self.get_first_column_map()
521519
self.get_link_map()
522520

523521
def convert_metadata(self):
@@ -679,8 +677,7 @@ def convert_tables(self):
679677
table = self.table_map.get(table_name)
680678
if not table:
681679
airtable_columns = self.airtable_column_map[table_name]
682-
first_column_name = self.first_column_map.get(table_name) or \
683-
airtable_columns[0]['name']
680+
first_column_name = airtable_columns[0]['name']
684681
columns = []
685682
for column in airtable_columns:
686683
if column['type'] == ColumnTypes.LINK:
@@ -788,14 +785,6 @@ def delete_demo_rows(self):
788785
logger.info('Demo rows deleted from SeaTable base')
789786
time.sleep(1)
790787

791-
def get_first_column_map(self):
792-
self.first_column_map = {}
793-
for column in self.first_columns:
794-
table_name = column[0]
795-
column_name = column[1]
796-
self.first_column_map[table_name] = column_name
797-
return self.first_column_map
798-
799788
def get_link_map(self):
800789
self.link_map = {}
801790
for link in self.links:

0 commit comments

Comments
 (0)