feat: Sandbox flatpak-system-update.service#1940
feat: Sandbox flatpak-system-update.service#1940Exponent64 wants to merge 18 commits intosecureblue:livefrom
Conversation
HastD
left a comment
There was a problem hiding this comment.
Thanks for working on this. At this point, it looks good to me in the abstract, but I haven't tested it yet to make sure it actually works and doesn't block intended functionality. What testing have you done with this so far?
So far, I have tested the sandboxed service on a kinoite-main-hardened image, always using the latest image available, in a vm under the qemu user session, and it has worked exactly the same as if it were unsandboxed. It succeeds when running |
|
Something I have to mention, though, is that when a system remote is present in the system, the service will fail when trying to run |
|
Just to clearly state the sort of testing I'd like to see for this: I'd want this to be tested on a system with a variety of flatpaks installed in a system installation, including some flatpaks like Steam that have more complex install hooks. The testing should also cover the case when updates are actually installed, not just checking for updates and not finding any. The failure mode here would be flatpaks (likely silently) failing to update, which is something we definitely want to avoid, so this needs thorough testing. |
|
@HastD Would it help if we add a line like |
Up to standards ✅🟢 Issues
|
This PR attempts to make some progress on the issue #114. It reduces the level of exposure of the flatpak-system-update service from 9.6 to 1.4. Unfortunately, the
ExecConditionof the service makes having access to /run/dbus a requirement, and therefore, it is still trivial to escape the sandbox.