add more tests for analytics builder (segmentio#129)

f2prateek · web-flow · commit 5cafcc9ff5d6 · 2018-08-15T14:16:12.000-07:00
diff --git a/analytics/src/test/java/com/segment/analytics/AnalyticsBuilderTest.java b/analytics/src/test/java/com/segment/analytics/AnalyticsBuilderTest.java
@@ -5,6 +5,8 @@
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.verify;
 
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.ThreadFactory;
 import java.util.concurrent.TimeUnit;
 import org.junit.Before;
 import org.junit.Test;
@@ -113,6 +115,12 @@ public void duplicateTransformer() {
     }
   }
 
+  @Test
+  public void buildsWithValidTransformer() {
+    Analytics analytics = builder.messageTransformer(mock(MessageTransformer.class)).build();
+    assertThat(analytics).isNotNull();
+  }
+
   @Test
   public void nullInterceptor() {
     try {
@@ -134,6 +142,12 @@ public void duplicateInterceptor() {
     }
   }
 
+  @Test
+  public void buildsWithValidInterceptor() {
+    Analytics analytics = builder.messageInterceptor(mock(MessageInterceptor.class)).build();
+    assertThat(analytics).isNotNull();
+  }
+
   @Test
   public void invalidFlushQueueSize() {
     try {
@@ -151,6 +165,12 @@ public void invalidFlushQueueSize() {
     }
   }
 
+  @Test
+  public void buildsWithValidFlushQueueSize() {
+    Analytics analytics = builder.flushQueueSize(1).build();
+    assertThat(analytics).isNotNull();
+  }
+
   @Test
   public void invalidFlushInterval() {
     try {
@@ -176,6 +196,12 @@ public void invalidFlushInterval() {
     }
   }
 
+  @Test
+  public void buildsWithValidFlushInterval() {
+    Analytics analytics = builder.flushInterval(2, TimeUnit.SECONDS).build();
+    assertThat(analytics).isNotNull();
+  }
+
   @Test
   public void nullNetworkExecutor() {
     try {
@@ -186,6 +212,12 @@ public void nullNetworkExecutor() {
     }
   }
 
+  @Test
+  public void buildsWithValidNetworkExecutor() {
+    Analytics analytics = builder.networkExecutor(mock(ExecutorService.class)).build();
+    assertThat(analytics).isNotNull();
+  }
+
   @Test
   public void nullEndpoint() {
     try {
@@ -213,6 +245,12 @@ public void emptyEndpoint() {
     }
   }
 
+  @Test
+  public void buildsWithValidEndpoint() {
+    Analytics analytics = builder.endpoint("https://api.segment.io").build();
+    assertThat(analytics).isNotNull();
+  }
+
   @Test
   public void nullThreadFactory() {
     try {
@@ -223,6 +261,12 @@ public void nullThreadFactory() {
     }
   }
 
+  @Test
+  public void buildsWithThreadFactory() {
+    Analytics analytics = builder.threadFactory(mock(ThreadFactory.class)).build();
+    assertThat(analytics).isNotNull();
+  }
+
   @Test
   public void nullCallback() {
     try {
@@ -233,6 +277,30 @@ public void nullCallback() {
     }
   }
 
+  @Test
+  public void duplicateCallback() {
+    Callback callback = mock(Callback.class);
+    try {
+      builder.callback(callback).callback(callback);
+    } catch (IllegalStateException e) {
+      assertThat(e).hasMessage("Callback is already registered.");
+    }
+  }
+
+  @Test
+  public void buildsWithValidCallback() {
+    Analytics analytics = builder.callback(mock(Callback.class)).build();
+    assertThat(analytics).isNotNull();
+  }
+
+  @Test
+  public void multipleCallbacks() {
+    Analytics analytics =
+        builder.callback(mock(Callback.class)).callback(mock(Callback.class)).build();
+
+    assertThat(analytics).isNotNull();
+  }
+
   @Test
   public void nullPlugin() {
     try {
