Skip to content
This repository was archived by the owner on Apr 22, 2023. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-v0.x-archive
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: sgala/node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 4 commits
  • 6 files changed
  • 1 contributor

Commits on Jul 2, 2010

  1. Typo in comment, repeated "had"

    @sgala
    sgala committed Jul 2, 2010
    Configuration menu
    Copy the full SHA
    0fe062f View commit details
    Browse the repository at this point in the history

  2. The test was failing because of typo in dns.js 

    resolve( addr, "PTR", cb) was failing
    @sgala
    sgala committed Jul 2, 2010
    Configuration menu
    Copy the full SHA
    07af0f6 View commit details
    Browse the repository at this point in the history

  3. Error in sample code in api documentation 

    Due to scope of var a, the printed address was typically
the last one in loop.
    @sgala
    sgala committed Jul 2, 2010
    Configuration menu
    Copy the full SHA
    c42e17c View commit details
    Browse the repository at this point in the history

  4. This change enables use of HTTP CONNECT, for instance in a proxy. 

    In the code using it, the listener to upgrade should
create a TCP connection to the requested host/port,
write the answer ("200 Connection Established\r\n" or similar)
to the client and plug together both streams.
    @sgala
    sgala committed Jul 2, 2010
    Configuration menu
    Copy the full SHA
    9c7a26d View commit details
    Browse the repository at this point in the history
Loading